refactor(obstacle_collision_checker): delete default values #2945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:control
satoshi-ota
changed the title
satoshi-ota
changed the title
satoshi-ota
approved these changes
Feb 26, 2023
Codecov ReportBase: 11.53% // Head: 11.53% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2945 +/- ##
=======================================
Coverage 11.53% 11.53%
=======================================
Files 1314 1314
Lines 92793 92784 -9
Branches 24996 24996
=======================================
Hits 10700 10700
+ Misses 70852 70843 -9
Partials 11241 11241
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
satoshi-ota
changed the title
Signed-off-by: yamazakiTasuku <tasuku.yamazaki@tier4.jp>
satoshi-ota
force-pushed
the
obstacle_collision_checker_delete_param
branch
from
3f5c6ab
to
0f1f8e8
Compare
satoshi-ota
requested review from
rej55,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168 and
tkimura4
as code owners
nabetetsu
pushed a commit
to xygyo77/autoware.universe
that referenced
this pull request
Mar 1, 2023
…foundation#2945) delete param Signed-off-by: yamazakiTasuku <tasuku.yamazaki@tier4.jp> Co-authored-by: yamazakiTasuku <tasuku.yamazaki@tier4.jp>
1222-takeshi
pushed a commit
to 1222-takeshi/autoware.universe
that referenced
this pull request
Mar 6, 2023
…foundation#2945) delete param Signed-off-by: yamazakiTasuku <tasuku.yamazaki@tier4.jp> Co-authored-by: yamazakiTasuku <tasuku.yamazaki@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed default values defined in declare_parameter function.
obstacle_collision_checker_delete_param.webm
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.