Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(typo): fix typos in comment #2999

Merged
merged 8 commits into from
Mar 4, 2023

Conversation

HansRobo
Copy link
Member

@HansRobo HansRobo commented Mar 3, 2023

Description

Fix typos in source code comments

This pull request is a part of #2841

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) labels Mar 3, 2023
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HansRobo HansRobo changed the title chore(typo): fix typos chore(typo): fix typos in comment Mar 3, 2023
@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01 🎉

Comparison is base (9dd2100) 12.79% compared to head (21d4c5b) 12.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2999      +/-   ##
==========================================
+ Coverage   12.79%   12.80%   +0.01%     
==========================================
  Files        1214     1214              
  Lines       85648    85579      -69     
  Branches    24281    24233      -48     
==========================================
  Hits        10959    10959              
+ Misses      63336    63267      -69     
  Partials    11353    11353              
Flag Coverage Δ *Carryforward flag
differential 8.61% <ø> (?)
total 12.80% <ø> (+0.01%) ⬆️ Carriedforward from 9dd2100

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...nal_controller/src/pid_longitudinal_controller.cpp 39.75% <ø> (ø)
..._tracker/src/tracker/model/big_vehicle_tracker.cpp 0.00% <ø> (ø)
...havior_path_planner/behavior_path_planner_node.hpp 0.00% <ø> (ø)
...ner/include/behavior_path_planner/data_manager.hpp 21.42% <ø> (ø)
...lanner/scene_module/pull_over/pull_over_module.hpp 0.00% <ø> (ø)
..._planner/util/pull_over/pull_over_planner_base.hpp 0.00% <ø> (ø)
...lanner/include/behavior_path_planner/utilities.hpp 23.80% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 0.15% <ø> (ø)
...nning/behavior_path_planner/src/path_utilities.cpp 0.00% <ø> (ø)
...er/src/scene_module/pull_over/pull_over_module.cpp 0.00% <ø> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HansRobo
Copy link
Member Author

HansRobo commented Mar 4, 2023

Thank you for your reviews!
All changes were approved by code owners, but I cannot merge because I don't have write access.

Could you merge this pull request?

@soblin soblin merged commit 8b8a37e into autowarefoundation:main Mar 4, 2023
@HansRobo
Copy link
Member Author

HansRobo commented Mar 4, 2023

@soblin Thanks!!

@HansRobo HansRobo deleted the destory-typos branch March 4, 2023 16:13
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request Mar 5, 2023
chore(typo): fix typos in comment (autowarefoundation#2999)

Co-authored-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
@takayuki5168
Copy link
Contributor

takayuki5168 commented Mar 6, 2023

@HansRobo Is this PR ready to merge?

Sorry, I reloaded the PR, and I found the PR was already merged.

1222-takeshi pushed a commit to 1222-takeshi/autoware.universe that referenced this pull request Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants