-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(lane_change): use BehaviorModuleOuput as output of generatePlannedPath #3508
chore(lane_change): use BehaviorModuleOuput as output of generatePlannedPath #3508
Conversation
…nedPath Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
c7f6be2
to
f17bb86
Compare
…>extendOutputDrivableArea Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
f17bb86
to
0e0c6bc
Compare
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3508 +/- ##
=======================================
Coverage 13.78% 13.79%
=======================================
Files 1391 1392 +1
Lines 97516 97501 -15
Branches 28875 28853 -22
=======================================
+ Hits 13446 13453 +7
+ Misses 69600 69595 -5
+ Partials 14470 14453 -17
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…nedPath (autowarefoundation#3508) * chore(lane_change): use BehaviorModuleOuput as output of generatePlannedPath Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * generatePlannedPath->generateOutput and generateExtendedDrivableArea->extendOutputDrivableArea Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * move assignment in plan to generateOutput Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix pointer error in new module Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Co-authored-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>
Description
For the following PR with which each module's output for drivable area will be drivable area information like drivable_lanes instead of drivable area line strings, the lane change module's output (generatePlannedPath's output) was changed from
Path
toBehavioModuleOutput
.tier4#373
Tests performed
planning simulator works well.
Effects on system behavior
Nothing
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.