Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lane_change): use BehaviorModuleOuput as output of generatePlannedPath #3508

Merged
merged 4 commits into from
Apr 24, 2023

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Apr 24, 2023

Description

For the following PR with which each module's output for drivable area will be drivable area information like drivable_lanes instead of drivable area line strings, the lane change module's output (generatePlannedPath's output) was changed from Path to BehavioModuleOutput.
tier4#373

Tests performed

planning simulator works well.

Effects on system behavior

Nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Apr 24, 2023
…nedPath

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 force-pushed the chore/change-lc-output branch 2 times, most recently from c7f6be2 to f17bb86 Compare April 24, 2023 02:11
…>extendOutputDrivableArea

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Patch coverage: 1.36% and no project coverage change.

Comparison is base (575b21d) 13.78% compared to head (03f13cc) 13.79%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3508   +/-   ##
=======================================
  Coverage   13.78%   13.79%           
=======================================
  Files        1391     1392    +1     
  Lines       97516    97501   -15     
  Branches    28875    28853   -22     
=======================================
+ Hits        13446    13453    +7     
+ Misses      69600    69595    -5     
+ Partials    14470    14453   -17     
Flag Coverage Δ *Carryforward flag
differential 12.41% <1.36%> (?)
total 13.80% <ø> (+0.01%) ⬆️ Carriedforward from 575b21d

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...anner/include/behavior_path_planner/parameters.hpp 0.00% <ø> (ø)
...th_planner/scene_module/lane_change/base_class.hpp 10.52% <ø> (ø)
...ane_change/external_request_lane_change_module.hpp 0.00% <ø> (ø)
...r_path_planner/scene_module/lane_change/normal.hpp 0.00% <ø> (ø)
...th_planner/scene_module/scene_module_interface.hpp 37.00% <0.00%> (-2.37%) ⬇️
..._planner/utils/avoidance/avoidance_module_data.hpp 0.00% <ø> (ø)
...anner/utils/drivable_area_expansion/parameters.hpp 20.00% <0.00%> (-3.34%) ⬇️
...nner/utils/lane_change/lane_change_module_data.hpp 50.00% <ø> (ø)
...ath_planner/utils/pull_out/pull_out_parameters.hpp 0.00% <ø> (ø)
...planner/utils/side_shift/side_shift_parameters.hpp 0.00% <ø> (ø)
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@takayuki5168 takayuki5168 changed the title Chore/change lc output chore(lane_change): use BehaviorModuleOuput as output of generatePlannedPath Apr 24, 2023
@takayuki5168 takayuki5168 marked this pull request as ready for review April 24, 2023 06:17
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@takayuki5168 takayuki5168 merged commit bc8ab77 into autowarefoundation:main Apr 24, 2023
Mingyu1991 pushed a commit to Mingyu1991/autoware.universe that referenced this pull request Jun 26, 2023
…nedPath (autowarefoundation#3508)

* chore(lane_change): use BehaviorModuleOuput as output of generatePlannedPath

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* generatePlannedPath->generateOutput and generateExtendedDrivableArea->extendOutputDrivableArea

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* move assignment in plan to generateOutput

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* fix pointer error in new module

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Co-authored-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 deleted the chore/change-lc-output branch July 12, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants