Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pull_over): minor change with drivable area expansion #3515

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Apr 24, 2023

Description

In pull over's drivable area generation

  • use different offsets for right and left offsets
  • margin is incorpolated into offset

working good
image

Tests performed

planning simulator works well

Effects on system behavior

Nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…ea expansion

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Apr 24, 2023
Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (bc8ab77) 13.74% compared to head (85fa413) 13.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3515      +/-   ##
==========================================
- Coverage   13.74%   13.73%   -0.02%     
==========================================
  Files        1392     1392              
  Lines       97856    98031     +175     
  Branches    29076    29219     +143     
==========================================
+ Hits        13452    13461       +9     
- Misses      69960    70110     +150     
- Partials    14444    14460      +16     
Flag Coverage Δ *Carryforward flag
differential 12.39% <0.00%> (?)
total 13.74% <ø> (+<0.01%) ⬆️ Carriedforward from cd0590f

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...nner/include/behavior_path_planner/utils/utils.hpp 100.00% <ø> (ø)
...lanner/src/utils/pull_over/freespace_pull_over.cpp 12.06% <0.00%> (ø)
planning/behavior_path_planner/src/utils/utils.cpp 18.02% <0.00%> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 changed the title feat(pull_over): can use different offsets for right left drivable area expansion feat(pull_over): minor change with drivable area expansion Apr 24, 2023
@takayuki5168 takayuki5168 merged commit f2b7687 into autowarefoundation:main Apr 24, 2023
@takayuki5168 takayuki5168 deleted the feat/freespace-drivable-area-right-left-offset branch April 24, 2023 16:07
Mingyu1991 pushed a commit to Mingyu1991/autoware.universe that referenced this pull request Jun 26, 2023
…oundation#3515)

* feat(pull_over): can use different offsets for right left drivable area expansion

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants