Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(lane_change): change prev info to non pointer #3659

Conversation

zulfaqar-azmi-t4
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 commented May 10, 2023

Description

🤖 Generated by Copilot at 1193734

This pull request refactors the lane change scene module classes in the behavior path planner to avoid using shared pointers for some member variables. This reduces memory overhead and improves performance. The files affected are base_class.hpp, normal.cpp, and avoidance_by_lane_change.cpp.

Related links

None

Tests performed

Compile in both new and old architecture.
Test using PSIM.

Notes for reviewers

None.

Interface changes

None

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Muhammad Zulfaqar <zulfaqar.azmi@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label May 10, 2023
Copy link
Contributor

@satoshi-ota satoshi-ota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2be9a34) 13.84% compared to head (1193734) 13.84%.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3659    +/-   ##
========================================
  Coverage   13.84%   13.84%            
========================================
  Files        1396     1396            
  Lines       98375    98521   +146     
  Branches    29310    29401    +91     
========================================
+ Hits        13617    13638    +21     
- Misses      69977    70080   +103     
- Partials    14781    14803    +22     
Flag Coverage Δ *Carryforward flag
differential 13.10% <0.00%> (?)
total 13.84% <ø> (+<0.01%) ⬆️ Carriedforward from 2be9a34

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...th_planner/scene_module/lane_change/base_class.hpp 8.88% <0.00%> (-1.12%) ⬇️
...ne_module/lane_change/avoidance_by_lane_change.cpp 0.00% <0.00%> (ø)
...th_planner/src/scene_module/lane_change/normal.cpp 6.62% <0.00%> (+0.03%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 merged commit af788b2 into autowarefoundation:main May 11, 2023
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Jun 20, 2023
…ation#3659)

Signed-off-by: Muhammad Zulfaqar <zulfaqar.azmi@tier4.jp>
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 deleted the refactor-lc-remove-pointer branch September 29, 2023 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants