fix(behavior_path_planner): extract backward obstacles correctly #3719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
github-actions
bot
added
the
component:planning
takayuki5168
requested review from
rej55,
kosuke55,
kyoichi-sugahara,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe,
tkimura4,
purewater0901,
zulfaqar-azmi-t4 and
a team
as code owners
purewater0901
approved these changes
May 15, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3719 +/- ##
==========================================
+ Coverage 14.55% 14.66% +0.10%
==========================================
Files 1409 1409
Lines 99298 100425 +1127
Branches 29378 30207 +829
==========================================
+ Hits 14457 14729 +272
- Misses 69258 69885 +627
- Partials 15583 15811 +228
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
takayuki5168
added a commit
to tier4/autoware.universe
that referenced
this pull request
May 16, 2023
…owarefoundation#3719) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
j4tfwm6z
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
May 25, 2023
…owarefoundation#3719) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
j4tfwm6z
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Jun 22, 2023
…owarefoundation#3719) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
takayuki5168
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jun 23, 2023
…owarefoundation#3719) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
takayuki5168
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jun 26, 2023
…owarefoundation#3719) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
1222-takeshi
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Jun 26, 2023
* feat(dynamic_avoidance): apply LPF to shift length, and positive relative velocity (autowarefoundation#4047) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * feat(dynamic_avoidance): suppress flickering of dynamic avoidance launching (autowarefoundation#4048) * feat(dynamic_avoidance): suppress flickering of dynamic avoidance launching Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update config Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * feat(dynamic_avoidance): ignore cut-out vehicle Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update cut out decision policy Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix(obstacle_avoidance_planner): smooth path connection after optimization (autowarefoundation#3754) * fix(obstacle_avoidance_planner): smooth path connection after optimization Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix(obstacle_avoidance_planner): fix optimization constraint for narrow-road driving (autowarefoundation#3701) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix(lane_change): copy drivable area info (autowarefoundation#3738) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(map_based_prediction): suppress lane change decision flickering (autowarefoundation#3788) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * feat(map_based_prediction): disable time delay compensation (autowarefoundation#3806) * disable time delay compensation Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * fix unused parameter Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * fix lane change decision not working problem due to empty future_lanenet in unconnected lanelets Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> --------- Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * fix(behavior_path_planner): boundary's nearest search (autowarefoundation#3716) * fix(behavior_path_planner): boundary's nearest search Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix(behavior_path_planner): extract backward obstacles correctly (autowarefoundation#3719) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix(behavior_path_planner): extract obstacles from drivable area without intersection (autowarefoundation#3741) * fix(behavior_path_planner): extract obstacles from drivable area without intersection Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update map_based_prediction method Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix(avoidance): fix invalid cherry pick Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com> Co-authored-by: Yoshi Ri <yoshiyoshidetteiu@gmail.com> Co-authored-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backward obstacle extraction from the drivable area is wrong in a case with a specific map.
without this PR
with this PR
Tests performed
planning simulator
Effects on system behavior
No behavior change
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.