Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dynamic_avoidance): ignore cut-out vehicle #4049

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Jun 22, 2023

Description

depends on
#4047
#4048

ignore dynamic avoidance for cut-out vehicle

Tests performed

planning simulator

Effects on system behavior

Not avoid cut-out vehicle

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 22, 2023
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 force-pushed the feat/dynamic-avoidance-ignore-cut-out-vehicle branch from 1b08493 to 8ebf417 Compare June 23, 2023 07:50
@takayuki5168 takayuki5168 marked this pull request as ready for review June 23, 2023 07:50
@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Patch coverage: 2.83% and project coverage change: +0.29 🎉

Comparison is base (3b162aa) 14.31% compared to head (8ebf417) 14.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4049      +/-   ##
==========================================
+ Coverage   14.31%   14.60%   +0.29%     
==========================================
  Files        1557     1570      +13     
  Lines      106900   107765     +865     
  Branches    30777    31309     +532     
==========================================
+ Hits        15302    15740     +438     
- Misses      75028    75056      +28     
- Partials    16570    16969     +399     
Flag Coverage Δ *Carryforward flag
differential 13.56% <2.83%> (?)
total 14.32% <ø> (+0.01%) ⬆️ Carriedforward from 3b162aa

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...id_map/laserscan_based_occupancy_grid_map_node.hpp 0.00% <ø> (ø)
...occupancy_grid_map_binary_bayes_filter_updater.hpp ∅ <ø> (∅)
...e/updater/occupancy_grid_map_updater_interface.hpp 0.00% <ø> (ø)
...id_map/laserscan_based_occupancy_grid_map_node.cpp 0.00% <ø> (ø)
...d_map/pointcloud_based_occupancy_grid_map_node.cpp 0.00% <ø> (ø)
...occupancy_grid_map_binary_bayes_filter_updater.cpp 0.00% <ø> (ø)
.../include/behavior_path_planner/planner_manager.hpp 18.86% <ø> (+18.86%) ⬆️
...ule/dynamic_avoidance/dynamic_avoidance_module.hpp 0.00% <0.00%> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 17.63% <0.00%> (-0.70%) ⬇️
...er/src/scene_module/avoidance/avoidance_module.cpp 13.16% <0.00%> (+9.02%) ⬆️
... and 6 more

... and 27 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@takayuki5168 takayuki5168 merged commit e70df12 into autowarefoundation:main Jun 23, 2023
@takayuki5168 takayuki5168 deleted the feat/dynamic-avoidance-ignore-cut-out-vehicle branch June 23, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants