Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(multi_object_tracker): tune system noise to suppress yaw oscillation #4679

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

YoshiRi
Copy link
Contributor

@YoshiRi YoshiRi commented Aug 21, 2023

Description

This PR provides performance tuning about tracking yaw oscillation problem in v42.

Tests performed

Tested with experimental rosbag files and simulations. See more details in TIER IV INTERNAL SLIDE.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Aug 21, 2023
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miursh miursh added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 23, 2023
@miursh miursh enabled auto-merge (squash) August 23, 2023 01:02
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8c5c20b) 14.89% compared to head (fa308ec) 14.89%.
Report is 49 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4679   +/-   ##
=======================================
  Coverage   14.89%   14.89%           
=======================================
  Files        1547     1547           
  Lines      106607   106607           
  Branches    32603    32603           
=======================================
  Hits        15876    15876           
  Misses      73426    73426           
  Partials    17305    17305           
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 14.89% <ø> (ø) Carriedforward from 8c5c20b

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...ject_tracker/src/tracker/model/bicycle_tracker.cpp 0.00% <ø> (ø)
..._tracker/src/tracker/model/big_vehicle_tracker.cpp 0.00% <ø> (ø)
...acker/src/tracker/model/normal_vehicle_tracker.cpp 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@miursh miursh merged commit 421edc1 into autowarefoundation:main Aug 23, 2023
34 checks passed
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Aug 23, 2023
…tion (autowarefoundation#4679)

* tune system noise to surpress yaw ossilation

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* style(pre-commit): autofix

---------

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Aug 23, 2023
…tion (autowarefoundation#4679)

* tune system noise to surpress yaw ossilation

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* style(pre-commit): autofix

---------

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
YoshiRi added a commit to tier4/autoware.universe that referenced this pull request Aug 23, 2023
…tion (autowarefoundation#4679)

* tune system noise to surpress yaw ossilation

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* style(pre-commit): autofix

---------

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request Aug 23, 2023
…tion (autowarefoundation#4679)

* tune system noise to surpress yaw ossilation

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* style(pre-commit): autofix

---------

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Aug 30, 2023
…tion (autowarefoundation#4679)

* tune system noise to surpress yaw ossilation

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* style(pre-commit): autofix

---------

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@YoshiRi YoshiRi deleted the feat/tracking_tuning_v43 branch October 16, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants