chore: sync upstream #765
Merged
chore: sync upstream #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![tier4-autoware-public-bot[bot]](https://avatars.githubusercontent.com/in/168304?s=60&v=4){kind=small}
…tion (autowarefoundation#4679) * tune system noise to surpress yaw ossilation Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * style(pre-commit): autofix --------- Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…ction.launch.xml (autowarefoundation#4596) * Update lidar_based_detection.launch.xml Some launch arguments were missing. These arguments and their defaults were added. Signed-off-by: Alireza Moayyedi <alireza.moayyedi@nobleo.nl> * changed default of objects_filter_method changed default of the "objects_filter_method" to "lanelet_filter" as requested. Signed-off-by: Alireza Moayyedi <alireza.moayyedi@nobleo.nl> --------- Signed-off-by: Alireza Moayyedi <alireza.moayyedi@nobleo.nl>
autowarefoundation#4599) * feat(vehicle_cmd_gate): variable filter limits for different vehicle speed Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * add steer diff test Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * add node test for vehicle_cmd_gate Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * update Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * update Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * update readme Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * add is_filter_activated msg Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * update Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * update is_activate for each field Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * update Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * Update control/vehicle_cmd_gate/src/vehicle_cmd_filter.cpp * add function test for interpolation Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * fix format Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * remove unused file Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * add missing depend Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> --------- Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
…on's declaration (autowarefoundation#4645) * refactor(freespace_planning_algorithms): delete default values of function declare_parameter * refactor(freespace_planning_algorithms): fix way to call declare_parameter function and add config repository. * refactor(freespace_planning_algorithms): fix way to declare declare_parameter function * fix(freespace_planner): add parameters for RRTStar search algorithm * style(pre-commit): autofix * refactor(freespace_planner): undo the change of planning algorithm --------- Signed-off-by: keiota <k3robot@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
…okupTransform exception in util function (autowarefoundation#4713) * add lookupTransform exception in util function and add launch_test Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * style(pre-commit): autofix --------- Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…chardJP's work) (autowarefoundation#4185) * perf(ring_outlier_filter): a cache friendly impl Signed-off-by: Vincent Richard <richard-v@macnica.co.jp> style(pre-commit): autofix fix(ring_outlier_filter): cleanup code with ranges Signed-off-by: Vincent Richard <richard-v@macnica.co.jp> [breaking] fix autoware point type padding for faster memory access can memcpy between input data buffer and PointXYZI* make assumption on memory layout for faster data fetch misc optimization (reordering, constexpr, etc) Signed-off-by: Vincent Richard <richard-v@macnica.co.jp> style(pre-commit): autofix comment limitations Signed-off-by: Vincent Richard <richard-v@macnica.co.jp> feat(ring_outlier_filter): add accurate isCluster impl Signed-off-by: Vincent Richard <richard-v@macnica.co.jp> style(pre-commit): autofix fix autowarefoundation#3218 Signed-off-by: Vincent Richard <richard-v@macnica.co.jp> cleaning Signed-off-by: Vincent Richard <richard-v@macnica.co.jp> style(pre-commit): autofix * style(pre-commit): autofix * resize vector to data size Signed-off-by: Vincent Richard <richard-v@macnica.co.jp> * cleaning Signed-off-by: Vincent Richard <richard-v@macnica.co.jp> * cleaner utilities impl Signed-off-by: Vincent Richard <richard-v@macnica.co.jp> * Correct ring_outlier_filter algorithm The implementation by VRichardJP was erroneously using indices into the input->fields array as byte offsets for copying values from the input. Added the missing step to access the offset of the field pointed at by the respective index. When combining the first and last walk, the num_points fields of the two walks need to be summed up as well. isCluster checks for num_points as well as distance. Signed-off-by: Maximilian Schmeller <maximilian.schmeller@tier4.jp> * Optimize memory usage of walks array The walks array in the previous implementation could in the worst case grow to the number of input points (if every point is an outlier). This increased computation time for gradually growing the walks vector. The current implementation only saves the first and current walk for every ring. The isCluster check is performed right when a walk is completed, and a bool vector akin to the previous walk_is_cluster vector is maintained. Signed-off-by: Maximilian Schmeller <maximilian.schmeller@tier4.jp> * Remove debug timers and outputs Signed-off-by: Maximilian Schmeller <maximilian.schmeller@tier4.jp> * style(pre-commit): autofix * Reduce amount of helper functions and data structures Remove functions for finding field offsets of Pointcloud2 points, replace them with the previous approach of assuming their position. This is okay since the ring_outlier_filter specification clearly states the expected pointcloud format. Remove accessor lambda functions for ring/azimuth/etc. because they are onlu used once anyways. Remove the walks vector and save the first/current walk structs directly in the RingWalkInfo struct. This makes the code more readable and maintainable. Signed-off-by: Maximilian Schmeller <maximilian.schmeller@tier4.jp> * style(pre-commit): autofix * Check for invalid pointcloud format In the previous revision (and before this PR), pointcloud field indices in ring_outlier_filter were hardcoded and fields were assumed to exist. VRichardJP solved this by implementing individual accessor functions, which ended up to be a bit verbose for this small piece of functionality. Now, there is one generic accessor function and the faster_filter function exits if any of the fields expected does not exist. The expected field data type is also checked. Signed-off-by: Maximilian Schmeller <maximilian.schmeller@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: Vincent Richard <richard-v@macnica.co.jp> Signed-off-by: Maximilian Schmeller <maximilian.schmeller@tier4.jp> Co-authored-by: Vincent Richard <richard-v@macnica.co.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Maximilian Schmeller <maximilian.schmeller@tier4.jp>
* feat(map_projection_loader, map_loader): rename utm to local_cartesian_utm Signed-off-by: kminoda <koji.minoda@tier4.jp> * fix readme Signed-off-by: kminoda <koji.minoda@tier4.jp> * fix default ad api Signed-off-by: kminoda <koji.minoda@tier4.jp> --------- Signed-off-by: kminoda <koji.minoda@tier4.jp>
… predicted path generation (autowarefoundation#4669) * add_pull_out_member_variables Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * update pull_out path struct Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * update pull_out path struct Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * minor update Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * fix calculation Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * fix build error Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * fix code Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * fix code Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
…autowarefoundation#4717) Signed-off-by: kminoda <koji.minoda@tier4.jp>
* feat(gnss_poser): remove plane coordinate Signed-off-by: kminoda <koji.minoda@tier4.jp> * style(pre-commit): autofix * remove geo_pos_conv Signed-off-by: kminoda <koji.minoda@tier4.jp> --------- Signed-off-by: kminoda <koji.minoda@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…tion#4702) * feat(gnss_poser): remove UTM projection in gnss_poser Signed-off-by: kminoda <koji.minoda@tier4.jp> * update readme Signed-off-by: kminoda <koji.minoda@tier4.jp> * style(pre-commit): autofix * remove coordinate_system from GNSSStat Signed-off-by: kminoda <koji.minoda@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: kminoda <koji.minoda@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…utowarefoundation#4678) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…dation#4643) * test(traffic_light_utils): add test_traffic_light_utils Signed-off-by: beginningfan <beginning.fan@autocore.ai> * style(pre-commit): autofix * fix(traffic_light_utils): fix magic number Signed-off-by: beginningfan <beginning.fan@autocore.ai> * style(pre-commit): autofix * fix(traffic_light_utils): fix namespace cpplint Signed-off-by: beginningfan <beginning.fan@autocore.ai> * style(pre-commit): autofix --------- Signed-off-by: beginningfan <beginning.fan@autocore.ai> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* fix(utils): fix longitudinal length inconsistency Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(utils): improve logic Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…ion#4714) * feat(glog): add glog component Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * formatting Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * remove namespace Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * remove license Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * Update launch/tier4_planning_launch/launch/scenario_planning/lane_driving/motion_planning/motion_planning.launch.py Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * Update launch/tier4_planning_launch/launch/scenario_planning/lane_driving/behavior_planning/behavior_planning.launch.py Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * Update common/glog_component/CMakeLists.txt Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * Update launch/tier4_control_launch/launch/control.launch.py Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * add copyright Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> --------- Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
…efoundation#4719) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…warefoundation#4720) * feat(obstacle_cruise_planner): add a hold stop distance feature Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * add param Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
tier4-autoware-public-bot
bot
requested review from
isamu-takagi,
tkhmy,
yabuta,
mitsudome-r,
yukkysaito,
amc-nu,
miursh,
YamatoAndo,
takayuki5168,
purewater0901,
kosuke55,
TakaHoribe and
rej55
as code owners
tier4-autoware-public-bot
bot
requested review from
kyoichi-sugahara,
satoshi-ota,
shmpwk,
taikitanaka3,
tkimura4 and
zulfaqar-azmi-t4
as code owners
tier4-autoware-public-bot
bot
requested review from
soblin,
YoshiRi,
kminoda,
Motsu-san,
RyuYamamoto,
KYabuuchi,
mkuri,
TomohitoAndo and
Mingyu1991
as code owners
github-actions
bot
added
documentation
tier4-autoware-public-bot
bot
merged commit c8ba613
into
tier4/main
9 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
Bug Fixes
Code Refactoring
Performance Improvements
Tests