Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_perception_launch): lower the detection by tracker priority to suppress yaw oscillation #4690

Merged

Conversation

YoshiRi
Copy link
Contributor

@YoshiRi YoshiRi commented Aug 22, 2023

Description

before after
image image
  • Problem
    • L-shape fitting process in detection_by_tracker sometimes fail to estimate correct yaw angle
    • This causes bad tracking/prediction result
  • Solution
    • By lower the detection_by_tracker priority, we can get more stable perception output

Related links

Ticket: TIER IV INTERNAL LINK

Tests performed

Tested with rosbag.

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
@YoshiRi YoshiRi requested a review from yukke42 August 22, 2023 01:48
@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Aug 22, 2023
Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YoshiRi YoshiRi enabled auto-merge (squash) August 22, 2023 01:54
@YoshiRi YoshiRi added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 22, 2023
@YoshiRi YoshiRi merged commit 7576edb into autowarefoundation:main Aug 22, 2023
26 checks passed
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Aug 23, 2023
…y to suppress yaw oscillation (autowarefoundation#4690)

lower the detection by tracker priority to suppress yaw oscillation

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
YoshiRi added a commit to tier4/autoware.universe that referenced this pull request Aug 23, 2023
…y to suppress yaw oscillation (autowarefoundation#4690)

lower the detection by tracker priority to suppress yaw oscillation

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request Aug 23, 2023
…y to suppress yaw oscillation (autowarefoundation#4690)

lower the detection by tracker priority to suppress yaw oscillation

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Aug 30, 2023
…y to suppress yaw oscillation (autowarefoundation#4690)

lower the detection by tracker priority to suppress yaw oscillation

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
@YoshiRi YoshiRi deleted the feat/lower_the_dbt_priority branch October 16, 2023 10:59
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Nov 26, 2023
…y to suppress yaw oscillation (autowarefoundation#4690)

lower the detection by tracker priority to suppress yaw oscillation

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Dec 25, 2023
…y to suppress yaw oscillation (autowarefoundation#4690)

lower the detection by tracker priority to suppress yaw oscillation

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants