-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(behavior_path_planner): renaming and comment collision check debug #4749
refactor(behavior_path_planner): renaming and comment collision check debug #4749
Conversation
… debug Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4749 +/- ##
==========================================
- Coverage 15.08% 15.03% -0.06%
==========================================
Files 1563 1563
Lines 107896 108601 +705
Branches 33111 33602 +491
==========================================
+ Hits 16272 16324 +52
- Misses 73868 74424 +556
- Partials 17756 17853 +97
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zulfaqar-azmi-t4
Very good 👍 super thanks!
Could you move visualize function to utils.cpp?
@kyoichi-sugahara |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
f7b8e49
to
6cb69d6
Compare
572cf8e
into
autowarefoundation:main
… debug (autowarefoundation#4749) * refactor(behavior_path_planner): renaming and comment collision check debug Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix spell check Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> --------- Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
…on check debug (autowarefoundation#4749)" This reverts commit 7c748a9.
… debug (autowarefoundation#4749) * refactor(behavior_path_planner): renaming and comment collision check debug Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix spell check Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> --------- Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Description
🤖 Generated by Copilot at 2335c67
This pull request improves the debug information and messages for the lane change module of the behavior path planner. It modifies the
CollisionCheckDebug
struct and the functions that use it inutils.hpp
,safety_check.cpp
, anddebug.cpp
to use more descriptive and consistent names and fields. It also updates theinterface.cpp
andnormal.cpp
files to use the modified struct and provide more informative and consistent debug messages.Tests performed
Compile autoware
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.