Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(behavior_path_planner): renaming and comment collision check debug #4749

Conversation

zulfaqar-azmi-t4
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 commented Aug 25, 2023

Description

🤖 Generated by Copilot at 2335c67

This pull request improves the debug information and messages for the lane change module of the behavior path planner. It modifies the CollisionCheckDebug struct and the functions that use it in utils.hpp, safety_check.cpp, and debug.cpp to use more descriptive and consistent names and fields. It also updates the interface.cpp and normal.cpp files to use the modified struct and provide more informative and consistent debug messages.

Tests performed

Compile autoware

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

… debug

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 25, 2023
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 25, 2023
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Patch coverage: 18.18% and project coverage change: -0.06% ⚠️

Comparison is base (b5e2c13) 15.08% compared to head (6cb69d6) 15.03%.
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4749      +/-   ##
==========================================
- Coverage   15.08%   15.03%   -0.06%     
==========================================
  Files        1563     1563              
  Lines      107896   108601     +705     
  Branches    33111    33602     +491     
==========================================
+ Hits        16272    16324      +52     
- Misses      73868    74424     +556     
- Partials    17756    17853      +97     
Flag Coverage Δ *Carryforward flag
differential 13.14% <18.18%> (?)
total 15.08% <ø> (-0.01%) ⬇️ Carriedforward from b5e2c13

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...clude/behavior_path_planner/marker_utils/utils.hpp 0.00% <ø> (ø)
...ath_planner/src/marker_utils/lane_change/debug.cpp 0.00% <0.00%> (ø)
...planner/src/scene_module/lane_change/interface.cpp 6.35% <0.00%> (+0.02%) ⬆️
...th_planner/src/scene_module/lane_change/normal.cpp 3.99% <0.00%> (-0.01%) ⬇️
...ner/src/utils/path_safety_checker/safety_check.cpp 26.85% <57.14%> (-5.69%) ⬇️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zulfaqar-azmi-t4
Very good 👍 super thanks!
Could you move visualize function to utils.cpp?

@zulfaqar-azmi-t4
Copy link
Contributor Author

@kyoichi-sugahara
Thank you. Sure, I will move the functions via another PR.

Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 force-pushed the refactor-collision-check-debug-renaming branch from f7b8e49 to 6cb69d6 Compare August 28, 2023 02:00
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 enabled auto-merge (squash) August 28, 2023 02:00
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 merged commit 572cf8e into autowarefoundation:main Aug 28, 2023
20 of 23 checks passed
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 deleted the refactor-collision-check-debug-renaming branch August 28, 2023 04:11
kyoichi-sugahara pushed a commit to tier4/autoware.universe that referenced this pull request Sep 12, 2023
… debug (autowarefoundation#4749)

* refactor(behavior_path_planner): renaming and comment collision check debug

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* fix spell check

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

---------

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
kyoichi-sugahara added a commit to tier4/autoware.universe that referenced this pull request Sep 12, 2023
zulfaqar-azmi-t4 added a commit to tier4/autoware.universe that referenced this pull request Sep 14, 2023
… debug (autowarefoundation#4749)

* refactor(behavior_path_planner): renaming and comment collision check debug

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* fix spell check

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

---------

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants