Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(safety_check): use light weight object position check logic #4762

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Aug 27, 2023

Description

🤖 Generated by Copilot at 49e3a85

This pull request adds a new feature to the behavior_path_planner package to check if an object is in front of the ego vehicle. It also fixes a bug in the safety_check.cpp file and adds a warning suppression attribute.

Tests performed

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 27, 2023
@satoshi-ota satoshi-ota marked this pull request as ready for review August 28, 2023 05:02
@satoshi-ota satoshi-ota added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 28, 2023
Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch coverage: 1.38% and project coverage change: -0.01% ⚠️

Comparison is base (e70531f) 15.11% compared to head (7b839b9) 15.10%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4762      +/-   ##
==========================================
- Coverage   15.11%   15.10%   -0.01%     
==========================================
  Files        1568     1568              
  Lines      108138   108171      +33     
  Branches    33188    33218      +30     
==========================================
- Hits        16345    16344       -1     
- Misses      73991    74008      +17     
- Partials    17802    17819      +17     
Flag Coverage Δ *Carryforward flag
differential 13.10% <1.38%> (?)
total 15.13% <ø> (+0.02%) ⬆️ Carriedforward from e70531f

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
..._planner/utils/avoidance/avoidance_module_data.hpp 0.00% <ø> (ø)
...h_planner/src/scene_module/lane_change/manager.cpp 5.34% <0.00%> (-1.29%) ⬇️
...ner/src/utils/path_safety_checker/safety_check.cpp 29.07% <0.00%> (-1.52%) ⬇️
...ath_planner/src/scene_module/avoidance/manager.cpp 6.17% <0.91%> (-0.36%) ⬇️
...er/src/scene_module/avoidance/avoidance_module.cpp 11.50% <20.00%> (-0.04%) ⬇️
...ehavior_path_planner/src/utils/avoidance/utils.cpp 9.66% <50.00%> (+0.11%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satoshi-ota satoshi-ota merged commit 06f4052 into autowarefoundation:main Aug 29, 2023
19 of 23 checks passed
@satoshi-ota satoshi-ota deleted the perf/safety-check branch August 29, 2023 02:06
satoshi-ota added a commit to satoshi-ota/autoware.universe that referenced this pull request Sep 11, 2023
…owarefoundation#4762)

perf(safety_check): use light weight object position check

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants