-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(safety_check): use light weight object position check logic #4762
perf(safety_check): use light weight object position check logic #4762
Conversation
d056bc5
to
49e3a85
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
49e3a85
to
7b839b9
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4762 +/- ##
==========================================
- Coverage 15.11% 15.10% -0.01%
==========================================
Files 1568 1568
Lines 108138 108171 +33
Branches 33188 33218 +30
==========================================
- Hits 16345 16344 -1
- Misses 73991 74008 +17
- Partials 17802 17819 +17
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
…owarefoundation#4762) perf(safety_check): use light weight object position check Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Description
🤖 Generated by Copilot at 49e3a85
This pull request adds a new feature to the
behavior_path_planner
package to check if an object is in front of the ego vehicle. It also fixes a bug in thesafety_check.cpp
file and adds a warning suppression attribute.Tests performed
Effects on system behavior
Nothing.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.