feat(tier4_autoware_utils): add getOrDeclearParam function #4763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
TakaHoribe
requested review from
takayuki5168 and
purewater0901
as code owners
github-actions
bot
added
the
component:common
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
TakaHoribe
added
the
tag:run-build-and-test-differential
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Comment on lines
36
to
39
| RCLCPP_ERROR( | ||
| node.get_logger(), "Failed to get parameter `%s`, please set it when you launch the node.", | ||
| name.c_str()); | ||
| throw(ex); |
There was a problem hiding this comment.
This error or warning is shown by default. Any reason to add this?
There was a problem hiding this comment.
Good. I just copied it from another pkg, but it can be removed.
There was a problem hiding this comment.
@takayuki5168 removed. Thank you!
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
takayuki5168
approved these changes
Aug 28, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4763 +/- ##
==========================================
- Coverage 15.10% 14.66% -0.45%
==========================================
Files 1563 1615 +52
Lines 107902 112219 +4317
Branches 33112 34093 +981
==========================================
+ Hits 16301 16457 +156
- Misses 73831 77824 +3993
- Partials 17770 17938 +168
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
takayuki5168
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 30, 2023
…oundation#4763) * feat(tier4_autoware_utils): add getOrDeclearParam function Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * modify utils.hpp Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * remove unused include Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * remove error message since it is shown by ros-default Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> --------- Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
takayuki5168
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 30, 2023
…oundation#4763) * feat(tier4_autoware_utils): add getOrDeclearParam function Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * modify utils.hpp Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * remove unused include Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * remove error message since it is shown by ros-default Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> --------- Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
satoshi-ota
pushed a commit
to satoshi-ota/autoware.universe
that referenced
this pull request
Sep 22, 2023
…oundation#4763) * feat(tier4_autoware_utils): add getOrDeclearParam function Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * modify utils.hpp Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * remove unused include Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * remove error message since it is shown by ros-default Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> --------- Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
takayuki5168
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 26, 2023
…oundation#4763) * feat(tier4_autoware_utils): add getOrDeclearParam function Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * modify utils.hpp Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * remove unused include Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * remove error message since it is shown by ros-default Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> --------- Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
takayuki5168
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 25, 2023
…oundation#4763) * feat(tier4_autoware_utils): add getOrDeclearParam function Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * modify utils.hpp Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * remove unused include Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * remove error message since it is shown by ros-default Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> --------- Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a new function to get ros param.
This function is copied from here
Related links
None
Tests performed
build pass
Notes for reviewers
None
Interface changes
None
Effects on system behavior
None
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.