Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(out_of_lane): use getOrDeclareParameter #4771

Merged
merged 3 commits into from
Aug 28, 2023

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Aug 28, 2023

Description

use tier4_autoware_utils::getOrDeclareParameter for the ros parameter to prevent duplicate parameter declaration.

Tests performed

Run psim

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 28, 2023
@TakaHoribe TakaHoribe marked this pull request as ready for review August 28, 2023 04:58
@TakaHoribe TakaHoribe added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 28, 2023
@TakaHoribe TakaHoribe enabled auto-merge (squash) August 28, 2023 05:02
@kminoda kminoda removed the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 28, 2023
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.03% 🎉

Comparison is base (e017725) 15.09% compared to head (1fc1001) 15.12%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4771      +/-   ##
==========================================
+ Coverage   15.09%   15.12%   +0.03%     
==========================================
  Files        1568     1563       -5     
  Lines      108130   107723     -407     
  Branches    33173    32980     -193     
==========================================
- Hits        16321    16297      -24     
+ Misses      74031    73765     -266     
+ Partials    17778    17661     -117     
Flag Coverage Δ *Carryforward flag
differential 24.02% <0.00%> (?)
total 15.13% <ø> (+0.03%) ⬆️ Carriedforward from d14488c

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...c/lanelet2_map_loader/lanelet2_map_loader_node.cpp 9.09% <ø> (+0.16%) ⬆️
...jection_loader/src/load_info_from_lanelet2_map.cpp 42.85% <ø> (+5.35%) ⬆️
...ap_projection_loader/src/map_projection_loader.cpp 25.00% <ø> (-3.58%) ⬇️
...n_loader/test/test_load_info_from_lanelet2_map.cpp 44.44% <ø> (+2.02%) ⬆️
...ior_velocity_detection_area_module/src/manager.cpp 52.00% <ø> (+12.60%) ⬆️
...avior_velocity_intersection_module/src/manager.cpp 24.53% <ø> (+5.40%) ⬆️
...r_velocity_no_stopping_area_module/src/manager.cpp 34.61% <ø> (+8.14%) ⬆️
...ior_velocity_occlusion_spot_module/src/manager.cpp 2.50% <ø> (+1.05%) ⬆️
...havior_velocity_out_of_lane_module/src/manager.cpp 19.56% <0.00%> (-1.37%) ⬇️
system/default_ad_api/src/vehicle.cpp 14.28% <ø> (+10.11%) ⬆️

... and 25 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kminoda kminoda added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 28, 2023
@TakaHoribe TakaHoribe merged commit d5204ab into autowarefoundation:main Aug 28, 2023
20 of 23 checks passed
@TakaHoribe TakaHoribe deleted the out_of_lane-get-param branch August 28, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants