-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(out_of_lane): use getOrDeclareParameter #4771
Merged
TakaHoribe
merged 3 commits into
autowarefoundation:main
from
tier4:out_of_lane-get-param
Aug 28, 2023
Merged
refactor(out_of_lane): use getOrDeclareParameter #4771
TakaHoribe
merged 3 commits into
autowarefoundation:main
from
tier4:out_of_lane-get-param
Aug 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
Aug 28, 2023
TakaHoribe
requested review from
maxime-clem,
shmpwk,
takayuki5168 and
tkimura4
as code owners
August 28, 2023 04:58
TakaHoribe
added
the
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Aug 28, 2023
takayuki5168
approved these changes
Aug 28, 2023
kminoda
removed
the
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Aug 28, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4771 +/- ##
==========================================
+ Coverage 15.09% 15.12% +0.03%
==========================================
Files 1568 1563 -5
Lines 108130 107723 -407
Branches 33173 32980 -193
==========================================
- Hits 16321 16297 -24
+ Misses 74031 73765 -266
+ Partials 17778 17661 -117
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
kminoda
added
the
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
use
tier4_autoware_utils::getOrDeclareParameter
for the ros parameter to prevent duplicate parameter declaration.Tests performed
Run psim
Effects on system behavior
None
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.