-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(autoware_auto_tf2): remove tf2 geometry function duplicated in tf2 geometry msgs #5089
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The base image for GitHub Actions is old and doesn't include the latest humble sync. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This reverts commit 19ab508.
…2 geometry msgs Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
c8d1865
to
da15a57
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5089 +/- ##
==========================================
- Coverage 14.89% 14.88% -0.02%
==========================================
Files 1625 1625
Lines 112449 112434 -15
Branches 34712 34711 -1
==========================================
- Hits 16752 16737 -15
Misses 76959 76959
Partials 18738 18738
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
…2 geometry msgs (backport autowarefoundation#5089) (#884) fix(autoware_auto_tf2): remove tf2 geometry function duplicated in tf2 geometry msgs (autowarefoundation#5089) Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
…2 geometry msgs (autowarefoundation#5089) (#887) Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
…2 geometry msgs (backport autowarefoundation#5089) (#884) fix(autoware_auto_tf2): remove tf2 geometry function duplicated in tf2 geometry msgs (autowarefoundation#5089) Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
…2 geometry msgs (backport autowarefoundation#5089) (#884) fix(autoware_auto_tf2): remove tf2 geometry function duplicated in tf2 geometry msgs (autowarefoundation#5089) Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> (cherry picked from commit 1b231f3)
…2 geometry msgs (backport autowarefoundation#5089) (backport #884) (#933) fix(autoware_auto_tf2): remove tf2 geometry function duplicated in tf2 geometry msgs (backport autowarefoundation#5089) (#884) fix(autoware_auto_tf2): remove tf2 geometry function duplicated in tf2 geometry msgs (autowarefoundation#5089) Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> (cherry picked from commit 1b231f3) Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
* fix(autoware_auto_tf2): remove tf2 geometry function duplicated in tf2 geometry msgs (#5089) * fix(tier4_screen_capture_panel): set format date --------- Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
…2 geometry msgs (autowarefoundation#5089) (#1038) Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Description
remove duplicated tf2 function introduced in this PR.
This causes build error as below.
This PR is necessary after next humble sync introduces tf2 geometry msgs 0.25.4.
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.