Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_auto_tf2): remove tf2 geometry function duplicated in tf2 geometry msgs #5089

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

wep21
Copy link
Contributor

@wep21 wep21 commented Sep 23, 2023

Description

remove duplicated tf2 function introduced in this PR.
This causes build error as below.

/home/daisuke/workspace/autoware/src/universe/autoware.universe/common/autoware_auto_tf2/include/autoware_auto_tf2/tf2_autoware_auto_msgs.hpp:60:13: error: redefinition of ‘void tf2::doTransform(const T&, T&, const TransformStamped&) [with T = geometry_msgs::msg::Point32_<std::allocator<void> >; geometry_msgs::msg::TransformStamped = geometry_msgs::msg::TransformStamped_<std::allocator<void> >]’
   60 | inline void doTransform(

This PR is necessary after next humble sync introduces tf2 geometry msgs 0.25.4.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Sep 23, 2023
@wep21 wep21 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 23, 2023
@wep21 wep21 marked this pull request as draft September 23, 2023 14:46
Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HansRobo
Copy link
Member

The base image for GitHub Actions is old and doesn't include the latest humble sync.
So, we have to update it.
But I have no permission to run docker-build-and-push-main workflow in awf/autoware repository.
Someone with the permission, could you please run the workflow?

Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…2 geometry msgs

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (19ab508) 14.89% compared to head (da15a57) 14.88%.
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5089      +/-   ##
==========================================
- Coverage   14.89%   14.88%   -0.02%     
==========================================
  Files        1625     1625              
  Lines      112449   112434      -15     
  Branches    34712    34711       -1     
==========================================
- Hits        16752    16737      -15     
  Misses      76959    76959              
  Partials    18738    18738              
Flag Coverage Δ *Carryforward flag
differential 16.22% <ø> (?)
total 14.88% <ø> (-0.02%) ⬇️ Carriedforward from 19ab508

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...clude/autoware_auto_tf2/tf2_autoware_auto_msgs.hpp 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wep21 wep21 merged commit 0373d21 into main Sep 27, 2023
23 of 24 checks passed
@wep21 wep21 deleted the remove-redefinition-tf2-function branch September 27, 2023 05:18
s-azumi pushed a commit to tier4/autoware.universe that referenced this pull request Sep 27, 2023
h-ohta pushed a commit to tier4/autoware.universe that referenced this pull request Sep 27, 2023
h-ohta added a commit to tier4/autoware.universe that referenced this pull request Sep 27, 2023
…2 geometry msgs (backport autowarefoundation#5089) (#884)

fix(autoware_auto_tf2): remove tf2 geometry function duplicated in tf2 geometry msgs (autowarefoundation#5089)

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
zhiwango pushed a commit to tier4/autoware.universe that referenced this pull request Sep 28, 2023
TakaHoribe pushed a commit to tier4/autoware.universe that referenced this pull request Sep 28, 2023
kazuki527 pushed a commit to tier4/autoware.universe that referenced this pull request Sep 28, 2023
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request Sep 28, 2023
…2 geometry msgs (autowarefoundation#5089) (#887)

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
maxime-clem pushed a commit to maxime-clem/autoware.universe that referenced this pull request Sep 28, 2023
soblin pushed a commit to tier4/autoware.universe that referenced this pull request Sep 28, 2023
maxime-clem pushed a commit to maxime-clem/autoware.universe that referenced this pull request Sep 29, 2023
YoheiMishina pushed a commit to tier4/autoware.universe that referenced this pull request Oct 2, 2023
…2 geometry msgs (backport autowarefoundation#5089) (#884)

fix(autoware_auto_tf2): remove tf2 geometry function duplicated in tf2 geometry msgs (autowarefoundation#5089)

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Oct 4, 2023
taikitanaka3 pushed a commit to taikitanaka3/autoware.universe that referenced this pull request Oct 5, 2023
taikitanaka3 added a commit that referenced this pull request Oct 5, 2023
…5232)

fix(autoware_auto_tf2): remove tf2 geometry function duplicated in tf2 geometry msgs (#5089)

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
mergify bot pushed a commit to tier4/autoware.universe that referenced this pull request Oct 12, 2023
…2 geometry msgs (backport autowarefoundation#5089) (#884)

fix(autoware_auto_tf2): remove tf2 geometry function duplicated in tf2 geometry msgs (autowarefoundation#5089)

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
(cherry picked from commit 1b231f3)
h-ohta added a commit to tier4/autoware.universe that referenced this pull request Oct 12, 2023
…2 geometry msgs (backport autowarefoundation#5089) (backport #884) (#933)

fix(autoware_auto_tf2): remove tf2 geometry function duplicated in tf2 geometry msgs (backport autowarefoundation#5089) (#884)

fix(autoware_auto_tf2): remove tf2 geometry function duplicated in tf2 geometry msgs (autowarefoundation#5089)

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
(cherry picked from commit 1b231f3)

Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
oguzkaganozt pushed a commit to leo-drive/avte.autoware_universe that referenced this pull request Oct 12, 2023
TetsuKawa pushed a commit to tier4/autoware.universe that referenced this pull request Nov 8, 2023
taikitanaka3 added a commit that referenced this pull request Nov 20, 2023
* fix(autoware_auto_tf2): remove tf2 geometry function duplicated in tf2 geometry msgs (#5089)

* fix(tier4_screen_capture_panel): set format date

---------

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
s-azumi pushed a commit to tier4/autoware.universe that referenced this pull request Nov 22, 2023
s-azumi added a commit to tier4/autoware.universe that referenced this pull request Nov 22, 2023
…2 geometry msgs (autowarefoundation#5089) (#1038)

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
maxime-clem pushed a commit to maxime-clem/autoware.universe that referenced this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants