-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add doTransform support for Point32, Polygon and PolygonStamped #616
Conversation
tf2_geometry_msgs/include/tf2_geometry_msgs/tf2_geometry_msgs.hpp
Outdated
Show resolved
Hide resolved
* \return The Vector3 converted to a geometry_msgs message type. | ||
*/ | ||
inline | ||
geometry_msgs::msg::Point32 & toMsg(const tf2::Vector3 & in, geometry_msgs::msg::Point32 & out) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using an argument and return for the same. Is there any reason to do so ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea, I just copied what was done for the geometry_msgs::msg::Point
:
geometry2/tf2_geometry_msgs/include/tf2_geometry_msgs/tf2_geometry_msgs.hpp
Lines 221 to 233 in 621be6b
/** \brief Convert a tf2 Vector3 type to its equivalent geometry_msgs representation. | |
* This function is a specialization of the toMsg template defined in tf2/convert.h. | |
* \param in A tf2 Vector3 object. | |
* \return The Vector3 converted to a geometry_msgs message type. | |
*/ | |
inline | |
geometry_msgs::msg::Point & toMsg(const tf2::Vector3 & in, geometry_msgs::msg::Point & out) | |
{ | |
out.x = in.getX(); | |
out.y = in.getY(); | |
out.z = in.getZ(); | |
return out; | |
} |
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/Mergifyio backport iron rolling |
✅ Backports have been created
|
Co-authored-by: Guillaume Doisy <guillaume@dexory.com> (cherry picked from commit 70d8c95)
Co-authored-by: Guillaume Doisy <guillaume@dexory.com> (cherry picked from commit 70d8c95)
…port #616) (#618) * Add doTransform support for Point32, Polygon and PolygonStamped (#616) Co-authored-by: Guillaume Doisy <guillaume@dexory.com> (cherry picked from commit 70d8c95) Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Point32 and PolygonStamped were in the python API but not the cpp one. Added them along with Polygon