-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(intersection): rectify initial accel/velocity profile in ego velocity profile #5496
Merged
soblin
merged 7 commits into
autowarefoundation:main
from
tier4:feat/intersection/rectify-accel-in-ttc-calculation
Nov 8, 2023
Merged
feat(intersection): rectify initial accel/velocity profile in ego velocity profile #5496
soblin
merged 7 commits into
autowarefoundation:main
from
tier4:feat/intersection/rectify-accel-in-ttc-calculation
Nov 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
Nov 6, 2023
soblin
force-pushed
the
feat/intersection/rectify-accel-in-ttc-calculation
branch
2 times, most recently
from
November 6, 2023 12:35
ae05b19
to
ed8826f
Compare
7 tasks
soblin
requested review from
isamu-takagi,
shmpwk,
tkimura4,
kyoichi-sugahara and
takayuki5168
as code owners
November 7, 2023 00:38
soblin
added
the
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Nov 7, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5496 +/- ##
==========================================
- Coverage 14.79% 14.76% -0.03%
==========================================
Files 1684 1684
Lines 116851 116870 +19
Branches 36274 36280 +6
==========================================
- Hits 17285 17260 -25
- Misses 80061 80118 +57
+ Partials 19505 19492 -13
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
soblin
force-pushed
the
feat/intersection/rectify-accel-in-ttc-calculation
branch
from
November 7, 2023 02:18
ed8826f
to
ff6f630
Compare
github-actions
bot
added
the
type:documentation
Creating or refining documentation. (auto-assigned)
label
Nov 7, 2023
soblin
added
tag:deploy-docs
Mark for deploy-docs action generation. (used-by-ci)
and removed
type:documentation
Creating or refining documentation. (auto-assigned)
labels
Nov 7, 2023
github-actions
bot
added
the
type:documentation
Creating or refining documentation. (auto-assigned)
label
Nov 7, 2023
soblin
force-pushed
the
feat/intersection/rectify-accel-in-ttc-calculation
branch
from
November 8, 2023 03:52
ff6f630
to
5f6e7ae
Compare
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…time_distance_array Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…p line is found Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin
force-pushed
the
feat/intersection/rectify-accel-in-ttc-calculation
branch
from
November 8, 2023 08:33
5f6e7ae
to
0fc38ad
Compare
takayuki5168
approved these changes
Nov 8, 2023
shmpwk
approved these changes
Nov 8, 2023
kminoda
pushed a commit
to kminoda/autoware.universe
that referenced
this pull request
Nov 9, 2023
…ocity profile (autowarefoundation#5496) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin
added a commit
to soblin/autoware.universe
that referenced
this pull request
Nov 18, 2023
…ocity profile (autowarefoundation#5496) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
takayuki5168
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 22, 2023
…ocity profile (autowarefoundation#5496) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
kyoichi-sugahara
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 29, 2023
…ocity profile (autowarefoundation#5496) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
4 tasks
satoshi-ota
pushed a commit
to satoshi-ota/autoware.universe
that referenced
this pull request
Jan 14, 2024
…ocity profile (autowarefoundation#5496) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
tag:deploy-docs
Mark for deploy-docs action generation. (used-by-ci)
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
type:documentation
Creating or refining documentation. (auto-assigned)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I fixed
calcIntersectionPassingTime
tosmoothPath
to entire path and then extract part of path points around ego vehicle to calculate time-distance profilelauncher PR: autowarefoundation/autoware_launch#677
Related links
Tests performed
evaluator: https://evaluation.tier4.jp/evaluation/reports/1fda8996-ef3a-5212-a330-087b50484408?project_id=prd_jt
Before this PR
chattering was happening
-2023-11-07_11.25.01.mp4
After this PR
PR5496-2023-11-08_17.34.51.mp4
Notes for reviewers
Interface changes
none.
Effects on system behavior
none.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.