Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(intersection): rectify initial accel/velocity profile in ego velocity profile #5496

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Nov 6, 2023

Description

I fixed calcIntersectionPassingTime to

  • apply smoothPath to entire path and then extract part of path points around ego vehicle to calculate time-distance profile
  • query stop line that is inserted from the upstream path

launcher PR: autowarefoundation/autoware_launch#677

Related links

Tests performed

evaluator: https://evaluation.tier4.jp/evaluation/reports/1fda8996-ef3a-5212-a330-087b50484408?project_id=prd_jt

Before this PR

chattering was happening

-2023-11-07_11.25.01.mp4

After this PR

PR5496-2023-11-08_17.34.51.mp4

Notes for reviewers

Interface changes

none.

Effects on system behavior

none.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 6, 2023
@soblin soblin force-pushed the feat/intersection/rectify-accel-in-ttc-calculation branch 2 times, most recently from ae05b19 to ed8826f Compare November 6, 2023 12:35
@soblin soblin marked this pull request as ready for review November 7, 2023 00:38
@soblin soblin added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 7, 2023
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Attention: 60 lines in your changes are missing coverage. Please review.

Comparison is base (df0b857) 14.79% compared to head (0fc38ad) 14.76%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5496      +/-   ##
==========================================
- Coverage   14.79%   14.76%   -0.03%     
==========================================
  Files        1684     1684              
  Lines      116851   116870      +19     
  Branches    36274    36280       +6     
==========================================
- Hits        17285    17260      -25     
- Misses      80061    80118      +57     
+ Partials    19505    19492      -13     
Flag Coverage Δ *Carryforward flag
differential 9.10% <0.00%> (?)
total 14.77% <0.00%> (-0.02%) ⬇️ Carriedforward from e02ec1b

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...lanner_common/src/utilization/trajectory_utils.cpp 0.00% <0.00%> (ø)
...behavior_velocity_intersection_module/src/util.cpp 0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin force-pushed the feat/intersection/rectify-accel-in-ttc-calculation branch from ed8826f to ff6f630 Compare November 7, 2023 02:18
@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Nov 7, 2023
@soblin soblin added tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) and removed type:documentation Creating or refining documentation. (auto-assigned) labels Nov 7, 2023
@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Nov 7, 2023
@soblin soblin force-pushed the feat/intersection/rectify-accel-in-ttc-calculation branch from ff6f630 to 5f6e7ae Compare November 8, 2023 03:52
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…time_distance_array

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…p line is found

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin force-pushed the feat/intersection/rectify-accel-in-ttc-calculation branch from 5f6e7ae to 0fc38ad Compare November 8, 2023 08:33
@soblin soblin merged commit fe35797 into autowarefoundation:main Nov 8, 2023
22 of 29 checks passed
@soblin soblin deleted the feat/intersection/rectify-accel-in-ttc-calculation branch November 8, 2023 09:17
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Nov 9, 2023
…ocity profile (autowarefoundation#5496)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin added a commit to soblin/autoware.universe that referenced this pull request Nov 18, 2023
…ocity profile (autowarefoundation#5496)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Nov 22, 2023
…ocity profile (autowarefoundation#5496)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
kyoichi-sugahara pushed a commit to tier4/autoware.universe that referenced this pull request Nov 29, 2023
…ocity profile (autowarefoundation#5496)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Jan 14, 2024
…ocity profile (autowarefoundation#5496)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants