Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ekf_localizer): add Simple1DFilter params to parameter file #5707

Merged
merged 5 commits into from
Dec 21, 2023
Merged

refactor(ekf_localizer): add Simple1DFilter params to parameter file #5707

merged 5 commits into from
Dec 21, 2023

Conversation

meliketanrikulu
Copy link
Contributor

@meliketanrikulu meliketanrikulu commented Nov 28, 2023 •
edited
Loading

Description

Simple1DFilter parameters will be added to the parameter file to be able to change these parameters from the parameter file.
Related PR :
autowarefoundation/autoware_launch#710

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:localization Vehicle's position determination in its environment. (auto-assigned) label Nov 28, 2023
@meliketanrikulu meliketanrikulu force-pushed the feat(ekf_localizer)addSimple1DFilterParams2ParamFile branch from 8dde2b5 to 3d03186 Compare November 28, 2023 15:40
This was referenced Nov 28, 2023
Merged
Closed
@kminoda kminoda added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 29, 2023
kminoda
kminoda reviewed Nov 29, 2023
View reviewed changes
Copy link
Contributor

@kminoda kminoda left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! Please fix the semantic-pull-request

localization/ekf_localizer/config/ekf_localizer.param.yaml Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Nov 29, 2023 •
edited
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (a427d29) 15.29% compared to head (7b434e4) 15.29%.
Report is 13 commits behind head on main.

Files Patch % Lines
...calizer/include/ekf_localizer/hyper_parameters.hpp 0.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5707   +/-   ##
=======================================
  Coverage   15.29%   15.29%           
=======================================
  Files        1747     1747           
  Lines      120251   120257    +6     
  Branches    36656    36659    +3     
=======================================
+ Hits        18392    18395    +3     
  Misses      81233    81233           
- Partials    20626    20629    +3
Flag Coverage Δ *Carryforward flag
differential 44.14% <50.00%> (?)
total 15.29% <ø> (ø) Carriedforward from a427d29

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

meliketanrikulu and others added 3 commits December 19, 2023 14:16
@meliketanrikulu
feat(ekf_localizer): Add Simple1DFilter params to parameter file
6e6420b 
Signed-off-by: meliketanrikulu <melike@leodrive.ai>
@pre-commit-ci @meliketanrikulu
style(pre-commit): autofix
039a4ac
@meliketanrikulu
feat(ekf_localizer): Add comment to param file
c0b48e1 
Signed-off-by: meliketanrikulu <melike@leodrive.ai>
@meliketanrikulu meliketanrikulu force-pushed the feat(ekf_localizer)addSimple1DFilterParams2ParamFile branch from 3d03186 to 5366ea3 Compare December 19, 2023 11:18
@meliketanrikulu
feat(ekf_localizer): Add Single1DFilter params to README.md
b75102d 
Signed-off-by: meliketanrikulu <melike@leodrive.ai>
@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Dec 19, 2023
@meliketanrikulu meliketanrikulu force-pushed the feat(ekf_localizer)addSimple1DFilterParams2ParamFile branch from 5366ea3 to b75102d Compare December 19, 2023 11:18
@YamatoAndo YamatoAndo changed the title feat(ekf_localizer): Add Simple1DFilter params to parameter file feat(ekf_localizer): add Simple1DFilter params to parameter file Dec 20, 2023
@kminoda kminoda changed the title feat(ekf_localizer): add Simple1DFilter params to parameter file refactor(ekf_localizer): add Simple1DFilter params to parameter file Dec 21, 2023
kminoda
kminoda approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
(I renamed the title prefix from feat to refactor, but open to discussion if you have any concerns for it)

@satoshi-ota satoshi-ota merged commit 7a8c798 into autowarefoundation:main Dec 21, 2023
28 of 31 checks passed
@meliketanrikulu
Copy link
Contributor Author

LGTM. (I renamed the title prefix from feat to refactor, but open to discussion if you have any concerns for it)

Thank you @kminoda . Could you check this PR too. it is related this PR :
autowarefoundation/autoware_launch#710

@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Jan 10, 2024
Merged
@meliketanrikulu meliketanrikulu self-assigned this May 22, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
@meliketanrikulu @pre-commit-ci @karishma1911
refactor(ekf_localizer): add Simple1DFilter params to parameter file (a…
d05e091 
…utowarefoundation#5707)

* feat(ekf_localizer): Add Simple1DFilter params to parameter file

Signed-off-by: meliketanrikulu <melike@leodrive.ai>

* style(pre-commit): autofix

* feat(ekf_localizer): Add comment to param file

Signed-off-by: meliketanrikulu <melike@leodrive.ai>

* feat(ekf_localizer): Add Single1DFilter  params to README.md

Signed-off-by: meliketanrikulu <melike@leodrive.ai>

* style(pre-commit): autofix

---------

Signed-off-by: meliketanrikulu <melike@leodrive.ai>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
@meliketanrikulu @pre-commit-ci @karishma1911
refactor(ekf_localizer): add Simple1DFilter params to parameter file (a…
ba885ed 
…utowarefoundation#5707)

* feat(ekf_localizer): Add Simple1DFilter params to parameter file

Signed-off-by: meliketanrikulu <melike@leodrive.ai>

* style(pre-commit): autofix

* feat(ekf_localizer): Add comment to param file

Signed-off-by: meliketanrikulu <melike@leodrive.ai>

* feat(ekf_localizer): Add Single1DFilter  params to README.md

Signed-off-by: meliketanrikulu <melike@leodrive.ai>

* style(pre-commit): autofix

---------

Signed-off-by: meliketanrikulu <melike@leodrive.ai>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
@meliketanrikulu @pre-commit-ci @karishma1911
refactor(ekf_localizer): add Simple1DFilter params to parameter file (a…
39c2172 
…utowarefoundation#5707)

* feat(ekf_localizer): Add Simple1DFilter params to parameter file

Signed-off-by: meliketanrikulu <melike@leodrive.ai>

* style(pre-commit): autofix

* feat(ekf_localizer): Add comment to param file

Signed-off-by: meliketanrikulu <melike@leodrive.ai>

* feat(ekf_localizer): Add Single1DFilter  params to README.md

Signed-off-by: meliketanrikulu <melike@leodrive.ai>

* style(pre-commit): autofix

---------

Signed-off-by: meliketanrikulu <melike@leodrive.ai>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
@meliketanrikulu @pre-commit-ci @karishma1911
refactor(ekf_localizer): add Simple1DFilter params to parameter file (a…
6a2512e 
…utowarefoundation#5707)

* feat(ekf_localizer): Add Simple1DFilter params to parameter file

Signed-off-by: meliketanrikulu <melike@leodrive.ai>

* style(pre-commit): autofix

* feat(ekf_localizer): Add comment to param file

Signed-off-by: meliketanrikulu <melike@leodrive.ai>

* feat(ekf_localizer): Add Single1DFilter  params to README.md

Signed-off-by: meliketanrikulu <melike@leodrive.ai>

* style(pre-commit): autofix

---------

Signed-off-by: meliketanrikulu <melike@leodrive.ai>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kminoda kminoda kminoda approved these changes

@Motsu-san Motsu-san Awaiting requested review from Motsu-san

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe

@IshitaTakeshi IshitaTakeshi Awaiting requested review from IshitaTakeshi

@YamatoAndo YamatoAndo Awaiting requested review from YamatoAndo

Assignees

@meliketanrikulu meliketanrikulu

Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meliketanrikulu @kminoda @satoshi-ota