-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(avoidance, avoidance_by_lane_change): separate package #5790
Merged
satoshi-ota
merged 4 commits into
autowarefoundation:main
from
satoshi-ota:refactor/separate-avoidance
Dec 7, 2023
Merged
refactor(avoidance, avoidance_by_lane_change): separate package #5790
satoshi-ota
merged 4 commits into
autowarefoundation:main
from
satoshi-ota:refactor/separate-avoidance
Dec 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
Dec 6, 2023
satoshi-ota
requested review from
rej55,
kosuke55,
kyoichi-sugahara,
soblin,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4 and
zulfaqar-azmi-t4
as code owners
December 6, 2023 02:28
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota
force-pushed
the
refactor/separate-avoidance
branch
from
December 6, 2023 02:29
c1ff3a2
to
1db66a3
Compare
satoshi-ota
added
the
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Dec 6, 2023
satoshi-ota
changed the title
refactor(avoidance, ablc): separate package
refactor(avoidance, avoidance_by_lane_change): separate package
Dec 6, 2023
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
kyoichi-sugahara
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
danielsanchezaran
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 15, 2023
…warefoundation#5790) * refactor(avoidance): separate package Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * refactor(AbLC): separate package Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * refactor(bpp): remove separate module Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(bpp): fix test error Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Dec 19, 2023
…warefoundation#5790) * refactor(avoidance): separate package Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * refactor(AbLC): separate package Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * refactor(bpp): remove separate module Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(bpp): fix test error Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: karishma <karishma@interpl.ai>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Dec 19, 2023
…warefoundation#5790) * refactor(avoidance): separate package Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * refactor(AbLC): separate package Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * refactor(bpp): remove separate module Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(bpp): fix test error Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: karishma <karishma@interpl.ai>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 26, 2024
…warefoundation#5790) * refactor(avoidance): separate package Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * refactor(AbLC): separate package Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * refactor(bpp): remove separate module Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(bpp): fix test error Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…warefoundation#5790) * refactor(avoidance): separate package Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * refactor(AbLC): separate package Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * refactor(bpp): remove separate module Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(bpp): fix test error Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…warefoundation#5790) * refactor(avoidance): separate package Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * refactor(AbLC): separate package Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * refactor(bpp): remove separate module Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(bpp): fix test error Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🤖[deprecated] Generated by Copilot at c1ff3a2
This pull request refactors the behavior path planner module into two separate modules:
behavior_path_avoidance_module
andbehavior_path_avoidance_by_lane_change_module
. The former handles the general obstacle and collision avoidance logic, while the latter handles the specific lane change avoidance logic. The pull request also renames, reorganizes, and updates some of the files, data structures, and classes in the new modules to improve the clarity and consistency of the code.Tests performed
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.