Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(avoidance, avoidance_by_lane_change): separate package #5790

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Dec 6, 2023

Description

🤖[deprecated] Generated by Copilot at c1ff3a2

This pull request refactors the behavior path planner module into two separate modules: behavior_path_avoidance_module and behavior_path_avoidance_by_lane_change_module. The former handles the general obstacle and collision avoidance logic, while the latter handles the specific lane change avoidance logic. The pull request also renames, reorganizes, and updates some of the files, data structures, and classes in the new modules to improve the clarity and consistency of the code.

Tests performed

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 6, 2023
@satoshi-ota satoshi-ota marked this pull request as ready for review December 6, 2023 02:28
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 6, 2023
@satoshi-ota satoshi-ota changed the title refactor(avoidance, ablc): separate package refactor(avoidance, avoidance_by_lane_change): separate package Dec 6, 2023
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 1692 lines in your changes are missing coverage. Please review.

Comparison is base (765a596) 15.32% compared to head (471f37f) 10.36%.
Report is 165 commits behind head on main.

Files Patch % Lines
...nning/behavior_path_avoidance_module/src/scene.cpp 13.04% 561 Missing and 92 partials ⚠️
...path_avoidance_module/src/shift_line_generator.cpp 13.19% 435 Missing and 65 partials ⚠️
...nning/behavior_path_avoidance_module/src/utils.cpp 3.75% 195 Missing and 10 partials ⚠️
...th_avoidance_by_lane_change_module/src/manager.cpp 17.70% 0 Missing and 79 partials ⚠️
...nning/behavior_path_avoidance_module/src/debug.cpp 0.00% 61 Missing ⚠️
...ing/behavior_path_avoidance_module/src/manager.cpp 18.86% 0 Missing and 43 partials ⚠️
...test/test_behavior_path_planner_node_interface.cpp 25.53% 0 Missing and 35 partials ⚠️
...test/test_behavior_path_planner_node_interface.cpp 26.08% 0 Missing and 34 partials ⚠️
...ning/behavior_path_planner/src/planner_manager.cpp 15.38% 10 Missing and 12 partials ⚠️
.../scene_module/goal_planner/goal_planner_module.hpp 9.52% 15 Missing and 4 partials ⚠️
... and 15 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5790       +/-   ##
===========================================
- Coverage   15.32%   10.36%    -4.96%     
===========================================
  Files        1721       86     -1635     
  Lines      118559    11196   -107363     
  Branches    37995     6282    -31713     
===========================================
- Hits        18169     1161    -17008     
+ Misses      79657     7804    -71853     
+ Partials    20733     2231    -18502     
Flag Coverage Δ
differential 10.36% <14.50%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@satoshi-ota satoshi-ota merged commit 13d45ae into autowarefoundation:main Dec 7, 2023
26 of 29 checks passed
@satoshi-ota satoshi-ota deleted the refactor/separate-avoidance branch December 7, 2023 01:33
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
…warefoundation#5790)

* refactor(avoidance): separate package

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* refactor(AbLC): separate package

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* refactor(bpp): remove separate module

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(bpp): fix test error

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
…warefoundation#5790)

* refactor(avoidance): separate package

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* refactor(AbLC): separate package

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* refactor(bpp): remove separate module

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(bpp): fix test error

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: karishma <karishma@interpl.ai>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
…warefoundation#5790)

* refactor(avoidance): separate package

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* refactor(AbLC): separate package

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* refactor(bpp): remove separate module

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(bpp): fix test error

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: karishma <karishma@interpl.ai>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
…warefoundation#5790)

* refactor(avoidance): separate package

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* refactor(AbLC): separate package

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* refactor(bpp): remove separate module

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(bpp): fix test error

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…warefoundation#5790)

* refactor(avoidance): separate package

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* refactor(AbLC): separate package

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* refactor(bpp): remove separate module

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(bpp): fix test error

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…warefoundation#5790)

* refactor(avoidance): separate package

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* refactor(AbLC): separate package

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* refactor(bpp): remove separate module

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(bpp): fix test error

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants