forked from autowarefoundation/autoware.universe
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: sync upstream #1078
Merged
Merged
chore: sync upstream #1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…asurementPose/Twist (autowarefoundation#5691) * Added X_delay_times_ to obtain the accumulated lap times of the timer callback. Added find_closest_index function to easily use the X_delay_times_. Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp> * Added a concept/variable of accumulated_delay_time_ and store every lap time of timer callback. The delay_step will be calculated from it, and the bug of calculating delay_step should be gone. Besides, removed dt in measurementUpdatePose/Twist since it is not needed. Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp> * Fixed dt to ekf_dt_ in predictUpdateFrequency() Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp> * Removed temporary debug stuff Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp> * style(pre-commit): autofix * Fixed code style pointed out from pre-commit.ci Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp> * style(pre-commit): autofix * Fixed typo Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp> * Removed variable ekf_rate_ which is currently unused. Added warnings when the ekf_dt_ is too large. Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp> * style(pre-commit): autofix * Changed threshold of delay time so that to look the most last (or largest) value of accumulated_delay_times_ Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp> * Correct the warning messages of diag_info to look up the last (or largest) value of accumulated_delay_times_ Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…foundation#5792) 1. The `updateData()` function now sets `status_.is_safe_dynamic_objects` to true when `requiresDynamicObjectsCollisionDetection()` returns false. 2. The `isExecutionReady()` function now checks for dynamic object collisions only if `requiresDynamicObjectsCollisionDetection()` returns true and `isWaitingApproval()` also returns true. This change ensures that dynamic object collision detection is performed only when necessary and approval is pending. Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
…dation#5782) * feat(start_planner): add surround moving obstacle check This commit introduces a new feature in the start_planner module for checking surrounding moving obstacles. - It adds parameters to specify the search radius and threshold velocity for moving obstacles, along with flags to indicate which types of objects should be checked. - The `noMovingObjectsAround` function has been added to filter dynamic objects within a certain radius based on their velocity. - If no moving objects are detected, the function returns true; otherwise, it returns false. - This feature enhances the safety of the start_planner by ensuring that the path can't be approved while surrond moving obstacles exist. --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
…warefoundation#5790) * refactor(avoidance): separate package Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * refactor(AbLC): separate package Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * refactor(bpp): remove separate module Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(bpp): fix test error Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: GitHub <noreply@github.com> Co-authored-by: github-actions <github-actions@github.com>
…utowarefoundation#5758) * refactor(motion_velocity_smoother): boost::optional to std::optional Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…dation#5802) * separate packages Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…ndation#5806) delete unnecessary TODO Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…ic signals with duplicated ids (autowarefoundation#5653) * fix: add operation to remove traffic signals with duplicated ids Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp> * feat: move operation into `crosswalk_traffic_light_estimator` Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp> --------- Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
…owarefoundation#5769) * rework multi object tracker parameters Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * update README Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * rework radar tracker parameter too Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> --------- Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
* fix typo * update comments Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
…utowarefoundation#5755) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
detection_by_tracker_param_path was missing Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
* refactor(lane_change): move lane change params Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(avoidance): remove unnecessary param path Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…imes to obtain accurate computation of delay_time (autowarefoundation#5821) Correct accumulated_delay_times in ekf_localizer so that the delay_step is computed accurately. Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
…utowarefoundation#5816) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
…ndation#5744) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
…5820) * refactor(side_shift): separate side shift module Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * refactor(bpp): remove side shift module Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…warefoundation#5689) fix(avoidance): output invalid avoidance path Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: GitHub <noreply@github.com> Co-authored-by: github-actions <github-actions@github.com>
…interpolate (autowarefoundation#5818) Fixed rejection criteria of SmartPoseBuffer::interpolate Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
…oid exceeding max voxel size (autowarefoundation#5824)
…utowarefoundation#5810) Add jerk and acc limits for slow-down Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>
…arefoundation#5819) * fix(traffic_light): stop if the traffic light signal timed out Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> * fix(traffic_light): fix README format Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> --------- Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
…c_time/elapsed_time, tentative objects (autowarefoundation#5762) * enable debugger in tracker Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * fix uninitialized class variable Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * feat: separate debugger class for simplification Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> --------- Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
…utowarefoundation#5830) Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
doc(intersection): add image Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…atus (autowarefoundation#5682) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
tier4-autoware-public-bot
bot
requested review from
s-azumi,
kminoda,
Motsu-san,
YamatoAndo,
mitsudome-r,
RyuYamamoto,
KYabuuchi,
SakodaShintaro and
IshitaTakeshi
as code owners
December 20, 2023 00:37
TakaHoribe
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
Bug Fixes
Documentation
Code Refactoring
behavior_path_planner_common
package (refactor(behavior_path_planner): move utils function tobehavior_path_planner_common
package autowarefoundation/autoware.universe#5877)Performance Improvements
Builds
Chores