-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add missing param on perception launch: #5812
Merged
technolojin
merged 1 commit into
autowarefoundation:main
from
technolojin:fix/perc_launch_missing_param_detect_by_track
Dec 8, 2023
Merged
fix: add missing param on perception launch: #5812
technolojin
merged 1 commit into
autowarefoundation:main
from
technolojin:fix/perc_launch_missing_param_detect_by_track
Dec 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
technolojin
requested review from
miursh,
YoshiRi and
yukkysaito
as code owners
December 8, 2023 02:20
github-actions
bot
added
the
component:launch
Launch files, scripts and initialization tools. (auto-assigned)
label
Dec 8, 2023
YoshiRi
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
detection_by_tracker_param_path was missing Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
technolojin
force-pushed
the
fix/perc_launch_missing_param_detect_by_track
branch
from
December 8, 2023 04:01
a6c44ab
to
56a067e
Compare
YoshiRi
added
the
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Dec 8, 2023
danielsanchezaran
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 15, 2023
detection_by_tracker_param_path was missing Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Dec 19, 2023
detection_by_tracker_param_path was missing Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> Signed-off-by: karishma <karishma@interpl.ai>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Dec 19, 2023
detection_by_tracker_param_path was missing Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> Signed-off-by: karishma <karishma@interpl.ai>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 26, 2024
detection_by_tracker_param_path was missing Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
detection_by_tracker_param_path was missing Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
detection_by_tracker_param_path was missing Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:launch
Launch files, scripts and initialization tools. (auto-assigned)
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
detection_by_tracker_param_path was missing
Description
A missing parameter
detection_by_tracker_param_path
on perception launch files is added.The configuration is aligned with the tier4 autoware.universe.
Tests performed
The system launch in a tier4 recompute environment.
Effects on system behavior
The perception module can be launched appropriately.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.