-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(crosswalk): update comments #5813
Merged
yuki-takagi-66
merged 5 commits into
autowarefoundation:main
from
tier4:chore/crosswalk-comments-update
Dec 8, 2023
Merged
chore(crosswalk): update comments #5813
yuki-takagi-66
merged 5 commits into
autowarefoundation:main
from
tier4:chore/crosswalk-comments-update
Dec 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
Dec 8, 2023
yuki-takagi-66
changed the title
Chore/crosswalk comments update
chore(crosswalk): update comments
Dec 8, 2023
yuki-takagi-66
force-pushed
the
chore/crosswalk-comments-update
branch
from
December 8, 2023 02:41
eda8a46
to
d9dec8f
Compare
yuki-takagi-66
requested review from
kyoichi-sugahara,
satoshi-ota,
shmpwk,
takayuki5168 and
tkimura4
as code owners
December 8, 2023 02:55
takayuki5168
approved these changes
Dec 8, 2023
takayuki5168
added
the
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Dec 8, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5813 +/- ##
==========================================
- Coverage 15.32% 9.21% -6.11%
==========================================
Files 1721 14 -1707
Lines 118559 1280 -117279
Branches 37995 755 -37240
==========================================
- Hits 18169 118 -18051
+ Misses 79657 907 -78750
+ Partials 20733 255 -20478
☔ View full report in Codecov by Sentry. |
yuki-takagi-66
merged commit Dec 8, 2023
0e9d1f0
into
autowarefoundation:main
32 of 34 checks passed
Merged
4 tasks
danielsanchezaran
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 15, 2023
* fix typo * update comments Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Dec 19, 2023
* fix typo * update comments Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> Signed-off-by: karishma <karishma@interpl.ai>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Dec 19, 2023
* fix typo * update comments Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> Signed-off-by: karishma <karishma@interpl.ai>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 26, 2024
* fix typo * update comments Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
* fix typo * update comments Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
* fix typo * update comments Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update comments for parameters
fix typo
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.