-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(detection_by_tracker): move utils.hpp file to the detection_by_tracker folder and namespace to avoid conflicts #5837
build(detection_by_tracker): move utils.hpp file to the detection_by_tracker folder and namespace to avoid conflicts #5837
Conversation
…tracker folder and namespace to avoid conflicts Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5837 +/- ##
=======================================
Coverage 15.27% 15.27%
=======================================
Files 1739 1739
Lines 119820 119820
Branches 36377 36377
=======================================
Hits 18306 18306
Misses 81030 81030
Partials 20484 20484
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…tracker folder and namespace to avoid conflicts (autowarefoundation#5837) * build(detection_by_tracker): move utils.hpp file to the detection_by_tracker folder and namespace to avoid conflicts Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…tracker folder and namespace to avoid conflicts (autowarefoundation#5837) * build(detection_by_tracker): move utils.hpp file to the detection_by_tracker folder and namespace to avoid conflicts Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: karishma <karishma@interpl.ai>
…tracker folder and namespace to avoid conflicts (autowarefoundation#5837) * build(detection_by_tracker): move utils.hpp file to the detection_by_tracker folder and namespace to avoid conflicts Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: karishma <karishma@interpl.ai>
…tracker folder and namespace to avoid conflicts (autowarefoundation#5837) * build(detection_by_tracker): move utils.hpp file to the detection_by_tracker folder and namespace to avoid conflicts Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…tracker folder and namespace to avoid conflicts (autowarefoundation#5837) * build(detection_by_tracker): move utils.hpp file to the detection_by_tracker folder and namespace to avoid conflicts Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…tracker folder and namespace to avoid conflicts (autowarefoundation#5837) * build(detection_by_tracker): move utils.hpp file to the detection_by_tracker folder and namespace to avoid conflicts Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Description
Move to a separate namespace and folder to avoid conflicts with other packages.
See #5826
See autowarefoundation/autoware#4070
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.