Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(detection_by_tracker): move utils.hpp file to the detection_by_tracker folder and namespace to avoid conflicts #5837

Merged

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Dec 11, 2023

Description

Move to a separate namespace and folder to avoid conflicts with other packages.

See #5826
See autowarefoundation/autoware#4070

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…tracker folder and namespace to avoid conflicts

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Dec 11, 2023
Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@esteve esteve added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 11, 2023
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (91290a3) 15.27% compared to head (b244517) 15.27%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5837   +/-   ##
=======================================
  Coverage   15.27%   15.27%           
=======================================
  Files        1739     1739           
  Lines      119820   119820           
  Branches    36377    36377           
=======================================
  Hits        18306    18306           
  Misses      81030    81030           
  Partials    20484    20484           
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 15.27% <ø> (ø) Carriedforward from 91290a3

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@esteve esteve merged commit dd3050a into autowarefoundation:main Dec 12, 2023
32 of 33 checks passed
@esteve esteve deleted the detection-by-tracker-move-utils branch December 12, 2023 13:53
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
…tracker folder and namespace to avoid conflicts (autowarefoundation#5837)

* build(detection_by_tracker): move utils.hpp file to the detection_by_tracker folder and namespace to avoid conflicts

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
…tracker folder and namespace to avoid conflicts (autowarefoundation#5837)

* build(detection_by_tracker): move utils.hpp file to the detection_by_tracker folder and namespace to avoid conflicts

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: karishma <karishma@interpl.ai>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
…tracker folder and namespace to avoid conflicts (autowarefoundation#5837)

* build(detection_by_tracker): move utils.hpp file to the detection_by_tracker folder and namespace to avoid conflicts

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: karishma <karishma@interpl.ai>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
…tracker folder and namespace to avoid conflicts (autowarefoundation#5837)

* build(detection_by_tracker): move utils.hpp file to the detection_by_tracker folder and namespace to avoid conflicts

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…tracker folder and namespace to avoid conflicts (autowarefoundation#5837)

* build(detection_by_tracker): move utils.hpp file to the detection_by_tracker folder and namespace to avoid conflicts

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…tracker folder and namespace to avoid conflicts (autowarefoundation#5837)

* build(detection_by_tracker): move utils.hpp file to the detection_by_tracker folder and namespace to avoid conflicts

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants