fix(landmark_manager): changed to a shared library #5848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>
SakodaShintaro
added
the
tag:run-build-and-test-differential
SakodaShintaro
requested review from
KYabuuchi,
Motsu-san and
YamatoAndo
as code owners
github-actions
bot
added
the
component:localization
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5848 +/- ##
=======================================
Coverage 15.30% 15.30%
=======================================
Files 1740 1740
Lines 119846 119846
Branches 36446 36446
=======================================
Hits 18348 18348
Misses 80969 80969
Partials 20529 20529
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SakodaShintaro
deleted the
fix/changed_landmark_manager_to_shared_lib
branch
danielsanchezaran
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 15, 2023
…n#5848) Changed landmark_manager to a shared library Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Dec 19, 2023
…n#5848) Changed landmark_manager to a shared library Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp> Signed-off-by: karishma <karishma@interpl.ai>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Dec 19, 2023
…n#5848) Changed landmark_manager to a shared library Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp> Signed-off-by: karishma <karishma@interpl.ai>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 26, 2024
…n#5848) Changed landmark_manager to a shared library Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…n#5848) Changed landmark_manager to a shared library Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…n#5848) Changed landmark_manager to a shared library Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed
landmark_managerto a shared libraryIt is just a mistake that I did not make it a shared library until now.
Tests performed
It has been confirmed that the
logging_simulatorruns with the same accuracy as before on AWSIM data with GT.Effects on system behavior
landmark_managerwill work as a shared library.Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.