Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(behavior_path_planner): move utils function to behavior_path_planner_common package #5877

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Dec 15, 2023

Description

🤖[deprecated] Generated by Copilot at 01d4f59

Moved the occupancy grid based collision detector to the behavior_path_planner_common module and updated the include statements and CMakeLists.txt files accordingly. Renamed the goal_planner_module.hpp header file to geometric_pull_over.hpp to clarify its functionality.

Tests performed

Psim

image

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 15, 2023
@satoshi-ota satoshi-ota added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 15, 2023
@satoshi-ota satoshi-ota marked this pull request as ready for review December 15, 2023 00:57
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0ae2685) 15.35% compared to head (01d4f59) 15.34%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5877      +/-   ##
==========================================
- Coverage   15.35%   15.34%   -0.02%     
==========================================
  Files        1747     1749       +2     
  Lines      120045   120135      +90     
  Branches    36534    36563      +29     
==========================================
  Hits        18430    18430              
- Misses      80962    81052      +90     
  Partials    20653    20653              
Flag Coverage Δ *Carryforward flag
differential 11.72% <ø> (?)
total 15.35% <ø> (+<0.01%) ⬆️ Carriedforward from 0ae2685

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satoshi-ota satoshi-ota merged commit 57278db into autowarefoundation:main Dec 15, 2023
46 checks passed
@satoshi-ota satoshi-ota deleted the refactor/bpp-common branch December 15, 2023 08:30
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
…h_planner_common` package (autowarefoundation#5877)

* refactor(bpp): remove unused header file

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* refactor(bpp, bpp-common): move occ grid based collision detector

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
…h_planner_common` package (autowarefoundation#5877)

* refactor(bpp): remove unused header file

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* refactor(bpp, bpp-common): move occ grid based collision detector

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: karishma <karishma@interpl.ai>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
…h_planner_common` package (autowarefoundation#5877)

* refactor(bpp): remove unused header file

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* refactor(bpp, bpp-common): move occ grid based collision detector

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: karishma <karishma@interpl.ai>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
…h_planner_common` package (autowarefoundation#5877)

* refactor(bpp): remove unused header file

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* refactor(bpp, bpp-common): move occ grid based collision detector

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…h_planner_common` package (autowarefoundation#5877)

* refactor(bpp): remove unused header file

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* refactor(bpp, bpp-common): move occ grid based collision detector

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…h_planner_common` package (autowarefoundation#5877)

* refactor(bpp): remove unused header file

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* refactor(bpp, bpp-common): move occ grid based collision detector

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Jun 6, 2024
…h_planner_common` package (autowarefoundation#5877)

* refactor(bpp): remove unused header file

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* refactor(bpp, bpp-common): move occ grid based collision detector

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants