Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(planning_debug_tools): improve calculation time of perception_reproducer #5894

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Dec 17, 2023

Description

Since the type of PredictedObjects is too large and copying the predicted objects is too heavy, the hertz of the perception_reproducer is sometimes less than 10, resulting in the published objects disappearing on Rviz.

This PR improved the calculation time of perception_reproducer when using predicted object mode.
Total time is

  • Before this PR: 50 - 80ms (sometimes 100 - 200ms and the objects disappear)
  • After this PR: 15 - 25ms

Tests performed

psim

Effects on system behavior

nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 17, 2023
@takayuki5168 takayuki5168 marked this pull request as ready for review December 17, 2023 09:52
@takayuki5168 takayuki5168 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 17, 2023
Copy link

codecov bot commented Dec 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2175b57) 15.29% compared to head (73834d1) 15.29%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5894   +/-   ##
=======================================
  Coverage   15.29%   15.29%           
=======================================
  Files        1747     1747           
  Lines      120123   120122    -1     
  Branches    36574    36573    -1     
=======================================
  Hits        18377    18377           
+ Misses      81129    81128    -1     
  Partials    20617    20617           
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 15.29% <ø> (+<0.01%) ⬆️ Carriedforward from 2175b57

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…producer

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 merged commit d06e42f into autowarefoundation:main Dec 18, 2023
23 of 24 checks passed
@takayuki5168 takayuki5168 deleted the perf/perception-reproducer branch December 18, 2023 05:25
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
…producer (autowarefoundation#5894)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: karishma <karishma@interpl.ai>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
…producer (autowarefoundation#5894)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: karishma <karishma@interpl.ai>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
…producer (autowarefoundation#5894)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…producer (autowarefoundation#5894)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…producer (autowarefoundation#5894)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants