feat(dynamic_avoidance): always launch the module when requested #5900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
takayuki5168
requested review from
rej55,
kosuke55,
kyoichi-sugahara,
satoshi-ota,
shmpwk,
TakaHoribe,
TomohitoAndo,
tkimura4 and
zulfaqar-azmi-t4
as code owners
github-actions
bot
added
the
component:planning
takayuki5168
added
the
tag:run-build-and-test-differential
satoshi-ota
approved these changes
Dec 18, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5900 +/- ##
==========================================
- Coverage 15.30% 15.28% -0.02%
==========================================
Files 1747 1747
Lines 120119 120557 +438
Branches 36570 36643 +73
==========================================
+ Hits 18380 18428 +48
- Misses 81124 81481 +357
- Partials 20615 20648 +33
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Dec 19, 2023
…owarefoundation#5900) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: karishma <karishma@interpl.ai>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Dec 19, 2023
…owarefoundation#5900) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: karishma <karishma@interpl.ai>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 26, 2024
…owarefoundation#5900) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…owarefoundation#5900) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…owarefoundation#5900) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Without the PR, the dynamic avoidance did not become the IDLE state when the avoidance module is WAITING_APPROVAL.
This PR makes the dynamic avoidance always IDLE when requested by using the isAlwaysExecutableModule function.
Tests performed
psim
Effects on system behavior
nothing
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.