-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: update TRT build log #6117
refactor: update TRT build log #6117
Conversation
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6117 +/- ##
==========================================
- Coverage 14.57% 14.56% -0.01%
==========================================
Files 1874 1874
Lines 127671 127706 +35
Branches 37317 37317
==========================================
Hits 18605 18605
- Misses 88145 88180 +35
Partials 20921 20921
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@ktro2828 |
Thanks your comment. |
@ktro2828
I completely agree with your opinion. Thanks for clarifying. |
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
@ktro2828 |
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
LGTM
* feat: add support of throttle logging Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp> * refactor: replace custom `Logger` to `tensorrt_common::Logger` Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp> * refactor: update to display standard output on screen Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp> * refactor: update log message while building engine from onnx Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp> * refactor: update logger in `lidar_centerpoint` Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp> * refactor: update log message Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp> * refactor: set default verbose=true for bulding engine from onnx Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp> * refactor: remove including unused `rclcpp.hpp` Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp> * refactor: update launcher to output logs on screen Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp> --------- Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp> Co-authored-by: Shunsuke Miura <37187849+miursh@users.noreply.github.com> Signed-off-by: anhnv3991 <anh.nguyen.2@tier4.jp>
* feat: add support of throttle logging Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp> * refactor: replace custom `Logger` to `tensorrt_common::Logger` Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp> * refactor: update to display standard output on screen Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp> * refactor: update log message while building engine from onnx Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp> * refactor: update logger in `lidar_centerpoint` Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp> * refactor: update log message Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp> * refactor: set default verbose=true for bulding engine from onnx Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp> * refactor: remove including unused `rclcpp.hpp` Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp> * refactor: update launcher to output logs on screen Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp> --------- Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp> Co-authored-by: Shunsuke Miura <37187849+miursh@users.noreply.github.com>
* feat: add support of throttle logging Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp> * refactor: replace custom `Logger` to `tensorrt_common::Logger` Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp> * refactor: update to display standard output on screen Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp> * refactor: update log message while building engine from onnx Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp> * refactor: update logger in `lidar_centerpoint` Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp> * refactor: update log message Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp> * refactor: set default verbose=true for bulding engine from onnx Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp> * refactor: remove including unused `rclcpp.hpp` Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp> * refactor: update launcher to output logs on screen Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp> --------- Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp> Co-authored-by: Shunsuke Miura <37187849+miursh@users.noreply.github.com>
Description
This PR updates to use throttle logging while building TRT engine from onnx every 5 seconds.
The target packages are as follows.
Sample usage
Tests performed
vokoscreenNG-2024-01-19_14-46-04.mp4
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.