Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ndt_scan_matcher): fix type of critical_upper_bound_exe_time_ms #6161

Conversation

YamatoAndo
Copy link
Contributor

@YamatoAndo YamatoAndo commented Jan 24, 2024

Merge with autowarefoundation/autoware_launch#819

Description

critical_upper_bound_exe_time_ms has been modified from int type to double type.

Tests performed

LSim works.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
@github-actions github-actions bot added the component:localization Vehicle's position determination in its environment. (auto-assigned) label Jan 24, 2024
@YamatoAndo YamatoAndo changed the title fix(ndt_scan_matcher): type of critical upper bound exe time ms fix(ndt_scan_matcher):fix type of critical upper bound exe time ms Jan 24, 2024
@YamatoAndo YamatoAndo changed the title fix(ndt_scan_matcher):fix type of critical upper bound exe time ms fix(ndt_scan_matcher):fix type of critical_upper_bound_exe_time_ms Jan 24, 2024
@YamatoAndo YamatoAndo marked this pull request as ready for review January 24, 2024 10:23
@KYabuuchi KYabuuchi added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 25, 2024
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (e4cae6f) 14.58% compared to head (b94d7b3) 14.58%.
Report is 8 commits behind head on main.

Files Patch % Lines
...ion/ndt_scan_matcher/src/ndt_scan_matcher_core.cpp 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6161   +/-   ##
=======================================
  Coverage   14.58%   14.58%           
=======================================
  Files        1868     1868           
  Lines      127493   127492    -1     
  Branches    37317    37316    -1     
=======================================
  Hits        18600    18600           
+ Misses      87974    87973    -1     
  Partials    20919    20919           
Flag Coverage Δ *Carryforward flag
differential 2.89% <0.00%> (?)
total 14.58% <ø> (+<0.01%) ⬆️ Carriedforward from e4cae6f

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YamatoAndo YamatoAndo changed the title fix(ndt_scan_matcher):fix type of critical_upper_bound_exe_time_ms fix(ndt_scan_matcher): fix type of critical_upper_bound_exe_time_ms Jan 25, 2024
@YamatoAndo YamatoAndo merged commit 1a9dbf4 into autowarefoundation:main Jan 25, 2024
36 of 42 checks passed
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jan 26, 2024
…utowarefoundation#6161)

* fix type of critical_upper_bound_exe_time_ms

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>

* fix order

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>

---------

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…utowarefoundation#6161)

* fix type of critical_upper_bound_exe_time_ms

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>

* fix order

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>

---------

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants