-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ndt_scan_matcher): fix type of critical_upper_bound_exe_time_ms #6161
Merged
YamatoAndo
merged 2 commits into
autowarefoundation:main
from
YamatoAndo:fix/type_of_critical_upper_bound_exe_time_ms
Jan 25, 2024
Merged
fix(ndt_scan_matcher): fix type of critical_upper_bound_exe_time_ms #6161
YamatoAndo
merged 2 commits into
autowarefoundation:main
from
YamatoAndo:fix/type_of_critical_upper_bound_exe_time_ms
Jan 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
github-actions
bot
added
the
component:localization
Vehicle's position determination in its environment. (auto-assigned)
label
Jan 24, 2024
YamatoAndo
changed the title
fix(ndt_scan_matcher): type of critical upper bound exe time ms
fix(ndt_scan_matcher):fix type of critical upper bound exe time ms
Jan 24, 2024
YamatoAndo
changed the title
fix(ndt_scan_matcher):fix type of critical upper bound exe time ms
fix(ndt_scan_matcher):fix type of critical_upper_bound_exe_time_ms
Jan 24, 2024
4 tasks
YamatoAndo
requested review from
KYabuuchi,
kminoda,
Motsu-san,
RyuYamamoto,
SakodaShintaro and
TaikiYamada4
as code owners
January 24, 2024 10:23
KYabuuchi
approved these changes
Jan 25, 2024
KYabuuchi
added
the
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Jan 25, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6161 +/- ##
=======================================
Coverage 14.58% 14.58%
=======================================
Files 1868 1868
Lines 127493 127492 -1
Branches 37317 37316 -1
=======================================
Hits 18600 18600
+ Misses 87974 87973 -1
Partials 20919 20919
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
YamatoAndo
changed the title
fix(ndt_scan_matcher):fix type of critical_upper_bound_exe_time_ms
fix(ndt_scan_matcher): fix type of critical_upper_bound_exe_time_ms
Jan 25, 2024
kminoda
pushed a commit
to kminoda/autoware.universe
that referenced
this pull request
Jan 26, 2024
…utowarefoundation#6161) * fix type of critical_upper_bound_exe_time_ms Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * fix order Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> --------- Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…utowarefoundation#6161) * fix type of critical_upper_bound_exe_time_ms Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * fix order Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> --------- Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:localization
Vehicle's position determination in its environment. (auto-assigned)
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge with autowarefoundation/autoware_launch#819
Description
critical_upper_bound_exe_time_ms
has been modified from int type to double type.Tests performed
LSim works.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.