chore(ar_tag_based_localizer): add json schema #6164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>
github-actions
bot
added
type:documentation
SakodaShintaro
added
the
tag:run-build-and-test-differential
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6164 +/- ##
=======================================
Coverage 14.59% 14.60%
=======================================
Files 1869 1869
Lines 127460 127421 -39
Branches 37310 37310
=======================================
Hits 18604 18604
+ Misses 87934 87895 -39
Partials 20922 20922
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SakodaShintaro
requested review from
KYabuuchi,
Motsu-san,
RyuYamamoto,
TaikiYamada4 and
YamatoAndo
as code owners
SakodaShintaro
merged commit 20ff907
into
autowarefoundation:main
26 of 27 checks passed
SakodaShintaro
deleted the
chore/add_json_schema_to_ar_tag_based_localizer
branch
kminoda
pushed a commit
to kminoda/autoware.universe
that referenced
this pull request
Jan 26, 2024
* Added json schema to AR tag-based localizer Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
* Added json schema to AR tag-based localizer Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add json schema
ar_tag_based_localizerAlso, added description creation to README using json schema.
As another unrelated fix, I addressed a warning that img alt text was not filled in.
Tests performed
N/A
Effects on system behavior
JSON Schema checking is enabled for
ar_tag_based_localizerPre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.