chore(image_projection_based_fusion): rework parameters #6169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kminoda <koji.minoda@tier4.jp>
kminoda
requested review from
badai-nguyen,
ktro2828,
miursh,
tzhong518,
YoshiRi,
yukkysaito and
yukke42
as code owners
github-actions
bot
added
the
component:perception
Merged
4 tasks
kminoda
added
the
tag:run-build-and-test-differential
kminoda
changed the title
yukkysaito
approved these changes
Jan 26, 2024
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
github-actions
bot
added
the
type:documentation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6169 +/- ##
==========================================
- Coverage 14.93% 14.39% -0.55%
==========================================
Files 1817 1906 +89
Lines 125140 129797 +4657
Branches 37617 37519 -98
==========================================
- Hits 18695 18686 -9
- Misses 85435 90150 +4715
+ Partials 21010 20961 -49
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kminoda
requested review from
amc-nu,
kyoichi-sugahara,
soblin,
shmpwk,
takayuki5168,
tkimura4,
knzo25,
anhnv3991 and
KYabuuchi
as code owners
kminoda
requested review from
SakodaShintaro,
TaikiYamada4,
YamatoAndo and
mitsudome-r
as code owners
kminoda
force-pushed
the
chore/image_projection_based_fusion/use_config
branch
from
0f44c93
to
b8c980e
Compare
…ed_fusion/use_config
Signed-off-by: kminoda <koji.minoda@tier4.jp>
kminoda
removed request for
knzo25,
RyuYamamoto,
amc-nu,
anhnv3991,
YamatoAndo,
takayuki5168,
KYabuuchi,
SakodaShintaro,
soblin,
kyoichi-sugahara,
shmpwk,
mitsudome-r,
tkimura4,
Motsu-san and
TaikiYamada4
4 tasks
anhnv3991
pushed a commit
to anhnv3991/autoware.universe
that referenced
this pull request
Feb 13, 2024
…dation#6169) * chore(image_projection_based_fusion): use config Signed-off-by: kminoda <koji.minoda@tier4.jp> * style(pre-commit): autofix * fix: revert build_only option Signed-off-by: kminoda <koji.minoda@tier4.jp> * docs: update readme Signed-off-by: kminoda <koji.minoda@tier4.jp> * style(pre-commit): autofix * update component launcher as well Signed-off-by: kminoda <koji.minoda@tier4.jp> --------- Signed-off-by: kminoda <koji.minoda@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Shin-kyoto
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Feb 27, 2024
…dation#6169) * chore(image_projection_based_fusion): use config Signed-off-by: kminoda <koji.minoda@tier4.jp> * style(pre-commit): autofix * fix: revert build_only option Signed-off-by: kminoda <koji.minoda@tier4.jp> * docs: update readme Signed-off-by: kminoda <koji.minoda@tier4.jp> * style(pre-commit): autofix * update component launcher as well Signed-off-by: kminoda <koji.minoda@tier4.jp> --------- Signed-off-by: kminoda <koji.minoda@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
shmpwk
added a commit
to tier4/autoware.universe
that referenced
this pull request
Feb 27, 2024
…ework chore(image_projection_based_fusion): rework parameters (autowarefoundation#6169)
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…dation#6169) * chore(image_projection_based_fusion): use config Signed-off-by: kminoda <koji.minoda@tier4.jp> * style(pre-commit): autofix * fix: revert build_only option Signed-off-by: kminoda <koji.minoda@tier4.jp> * docs: update readme Signed-off-by: kminoda <koji.minoda@tier4.jp> * style(pre-commit): autofix * update component launcher as well Signed-off-by: kminoda <koji.minoda@tier4.jp> --------- Signed-off-by: kminoda <koji.minoda@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use param file for image_projection_based_fusion
Must be merged with autowarefoundation/autoware_launch#824
Tests performed
Launch Autoware and confirm that the parameters are loaded successfully.
Effects on system behavior
No effect expected
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.