-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(yabloc): rework parameters #6170
chore(yabloc): rework parameters #6170
Conversation
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
This reverts commit 33d3e60.
This reverts commit 00ae417. Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
localization/yabloc/yabloc_image_processing/schema/graph_segment.schema.json
Outdated
Show resolved
Hide resolved
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Loooks Good To Me
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6170 +/- ##
=======================================
Coverage 14.58% 14.58%
=======================================
Files 1871 1871
Lines 127546 127546
Branches 37310 37310
=======================================
Hits 18606 18606
Misses 88020 88020
Partials 20920 20920
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
* introduce json schema for ground_server Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * introduce json schema for ll2_decomposer Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * style(pre-commit): autofix * fix json in yabloc_common Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * introduce json schema for graph_segment Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * introduce json schema for segment_filter Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * fix yabloc_common schema.json Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * introduce json schema for undistort Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * style(pre-commit): autofix * Revert "introduce json schema for ground_server" This reverts commit 33d3e60. * Revert "introduce json schema for graph_segment" This reverts commit 00ae417. Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * style(pre-commit): autofix * introduce json schema for yabloc_monitor Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * introduce json schema for yabloc_particle_filter Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * introduce json schema for yabloc_pose_initializer Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * apply pre-commit Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * fix revert conflict Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* introduce json schema for ground_server Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * introduce json schema for ll2_decomposer Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * style(pre-commit): autofix * fix json in yabloc_common Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * introduce json schema for graph_segment Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * introduce json schema for segment_filter Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * fix yabloc_common schema.json Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * introduce json schema for undistort Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * style(pre-commit): autofix * Revert "introduce json schema for ground_server" This reverts commit 33d3e60. * Revert "introduce json schema for graph_segment" This reverts commit 00ae417. Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * style(pre-commit): autofix * introduce json schema for yabloc_monitor Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * introduce json schema for yabloc_particle_filter Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * introduce json schema for yabloc_pose_initializer Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * apply pre-commit Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * fix revert conflict Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: anhnv3991 <anh.nguyen.2@tier4.jp>
* introduce json schema for ground_server Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * introduce json schema for ll2_decomposer Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * style(pre-commit): autofix * fix json in yabloc_common Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * introduce json schema for graph_segment Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * introduce json schema for segment_filter Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * fix yabloc_common schema.json Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * introduce json schema for undistort Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * style(pre-commit): autofix * Revert "introduce json schema for ground_server" This reverts commit 33d3e60. * Revert "introduce json schema for graph_segment" This reverts commit 00ae417. Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * style(pre-commit): autofix * introduce json schema for yabloc_monitor Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * introduce json schema for yabloc_particle_filter Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * introduce json schema for yabloc_pose_initializer Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * apply pre-commit Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * fix revert conflict Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Description
Added
*.schema.json
files for all yabloc packages. No other changes.Packages (nodes) to which schema is added
Tests performed
validation in local environment
I have confirmed the validation locally
and it outputs the following
github actions
✔️
README rendering
✔️
, then i have confirmed the parameters are rendered as below.
Effects on system behavior
Does not affect
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.