Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(yabloc): rework parameters #6170

Merged
merged 18 commits into from
Jan 25, 2024

Conversation

KYabuuchi
Copy link
Contributor

@KYabuuchi KYabuuchi commented Jan 25, 2024

Description

Added *.schema.json files for all yabloc packages. No other changes.

Packages (nodes) to which schema is added

  • yabloc_common/ground_server
  • yabloc_common/ll2_decomposer
  • yabloc_image_processing/graph_segment
  • yabloc_image_processing/segment_filter
  • yabloc_image_processing/undistort
  • yabloc_monitor/yabloc_monitor
  • yabloc_particle_filter/camera_particle_corrector
  • yabloc_particle_filter/gnss_particle_corrector
  • yabloc_particle_filter/predictor
  • yabloc_pose_initializer/camera_pose_initializer

Tests performed

validation in local environment

I have confirmed the validation locally

pip3 install -U check-jsonschema

cd autoware/src/universe/autoware.universe/localization/yabloc/
find -wholename '*/schema/*.schema.json' -printf '%p: ' -execdir bash -c 'check-jsonschema --schemafile "$1" ../config/"${1:2:-12}"*.param.yaml' bash '{}' +

and it outputs the following

./yabloc_monitor/schema/yabloc_monitor.schema.json: ok -- validation done
./yabloc_image_processing/schema/undistort.schema.json: ./yabloc_image_processing/schema/graph_segment.schema.json: ./yabloc_image_processing/schema/segment_filter.schema.json: ok -- validation done
./yabloc_common/schema/ground_server.schema.json: ./yabloc_common/schema/ll2_decomposer.schema.json: ok -- validation done
./yabloc_particle_filter/schema/gnss_particle_corrector.schema.json: ./yabloc_particle_filter/schema/camera_particle_corrector.schema.json: ./yabloc_particle_filter/schema/predictor.schema.json: ok -- validation done
./yabloc_pose_initializer/schema/camera_pose_initializer.schema.json: ok -- validation done

github actions

✔️
image

README rendering

✔️

cd autoware/src/universe/autoware.universe/
mkdocs serve

, then i have confirmed the parameters are rendered as below.
image

Effects on system behavior

Does not affect

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) labels Jan 25, 2024
pre-commit-ci bot and others added 7 commits January 25, 2024 05:19
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
@KYabuuchi KYabuuchi changed the title docs(yabloc_common): rework parameters docs(yabloc_common,yabloc_image_processing): rework parameters Jan 25, 2024
@KYabuuchi KYabuuchi changed the title docs(yabloc_common,yabloc_image_processing): rework parameters chore(yabloc_common,yabloc_image_processing): rework parameters Jan 25, 2024
KYabuuchi and others added 7 commits January 25, 2024 15:31
This reverts commit 00ae417.

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
@KYabuuchi KYabuuchi changed the title chore(yabloc_common,yabloc_image_processing): rework parameters chore(yabloc): rework parameters Jan 25, 2024
@KYabuuchi KYabuuchi marked this pull request as ready for review January 25, 2024 07:28
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
@KYabuuchi KYabuuchi added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 25, 2024
Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loooks Good To Me

@KYabuuchi KYabuuchi enabled auto-merge (squash) January 25, 2024 08:13
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (20ff907) 14.58% compared to head (2571dc4) 14.58%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6170   +/-   ##
=======================================
  Coverage   14.58%   14.58%           
=======================================
  Files        1871     1871           
  Lines      127546   127546           
  Branches    37310    37310           
=======================================
  Hits        18606    18606           
  Misses      88020    88020           
  Partials    20920    20920           
Flag Coverage Δ *Carryforward flag
differential 4.41% <ø> (?)
total 14.58% <ø> (ø) Carriedforward from 20ff907

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KYabuuchi KYabuuchi merged commit f0b8555 into autowarefoundation:main Jan 25, 2024
34 of 36 checks passed
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jan 26, 2024
* introduce json schema for ground_server

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* introduce json schema for ll2_decomposer

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* style(pre-commit): autofix

* fix json in yabloc_common

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* introduce json schema for graph_segment

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* introduce json schema for segment_filter

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* fix yabloc_common schema.json

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* introduce json schema for undistort

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* style(pre-commit): autofix

* Revert "introduce json schema for ground_server"

This reverts commit 33d3e60.

* Revert "introduce json schema for graph_segment"

This reverts commit 00ae417.

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* style(pre-commit): autofix

* introduce json schema for yabloc_monitor

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* introduce json schema for yabloc_particle_filter

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* introduce json schema for yabloc_pose_initializer

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* apply pre-commit

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* fix revert conflict

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@KYabuuchi KYabuuchi deleted the docs/yabloc_json_schema branch January 26, 2024 05:23
anhnv3991 pushed a commit to anhnv3991/autoware.universe that referenced this pull request Jan 29, 2024
* introduce json schema for ground_server

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* introduce json schema for ll2_decomposer

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* style(pre-commit): autofix

* fix json in yabloc_common

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* introduce json schema for graph_segment

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* introduce json schema for segment_filter

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* fix yabloc_common schema.json

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* introduce json schema for undistort

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* style(pre-commit): autofix

* Revert "introduce json schema for ground_server"

This reverts commit 33d3e60.

* Revert "introduce json schema for graph_segment"

This reverts commit 00ae417.

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* style(pre-commit): autofix

* introduce json schema for yabloc_monitor

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* introduce json schema for yabloc_particle_filter

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* introduce json schema for yabloc_pose_initializer

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* apply pre-commit

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* fix revert conflict

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: anhnv3991 <anh.nguyen.2@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
* introduce json schema for ground_server

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* introduce json schema for ll2_decomposer

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* style(pre-commit): autofix

* fix json in yabloc_common

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* introduce json schema for graph_segment

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* introduce json schema for segment_filter

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* fix yabloc_common schema.json

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* introduce json schema for undistort

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* style(pre-commit): autofix

* Revert "introduce json schema for ground_server"

This reverts commit 33d3e60.

* Revert "introduce json schema for graph_segment"

This reverts commit 00ae417.

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* style(pre-commit): autofix

* introduce json schema for yabloc_monitor

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* introduce json schema for yabloc_particle_filter

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* introduce json schema for yabloc_pose_initializer

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* apply pre-commit

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* fix revert conflict

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants