-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(lanelet2_map_loader): enrich error message #6245
chore(lanelet2_map_loader): enrich error message #6245
Conversation
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the pull request.
I think it is a good idea to make the log output more detailed.
Looks Good To Me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙆♂️
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6245 +/- ##
==========================================
- Coverage 14.39% 14.39% -0.01%
==========================================
Files 1906 1906
Lines 129847 129852 +5
Branches 37572 37577 +5
==========================================
Hits 18697 18697
- Misses 90155 90160 +5
Partials 20995 20995
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
f825ff0
into
autowarefoundation:main
…6245) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
…6245) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Description
Improve the error message when the map load fails.
Tests performed
run psim and check the error message.
Effects on system behavior
None
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.