Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(pre-commit): update pre-commit-hooks-ros #625

Merged
merged 2 commits into from
Apr 5, 2022

Conversation

kenji-miyake
Copy link
Contributor

See tier4/pre-commit-hooks-ros#50 and https://github.com/tier4/pre-commit-hooks-ros/releases/tag/v0.6.0.

Related: autowarefoundation/autoware#143

Note: Introducing prettier-launch-xml will probably cause drastic changes to files, so it can be commented out for now.

@kenji-miyake
Copy link
Contributor Author

Note: Introducing prettier-launch-xml will probably cause drastic changes to files, so it can be commented out for now.

@yukkysaito @xmfcx What do you think about introducing prettier-launch-xml to this repository?

@codecov
Copy link

codecov bot commented Apr 3, 2022

Codecov Report

Merging #625 (5c78e9b) into main (7d3ee50) will decrease coverage by 6.97%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             main    #625      +/-   ##
=========================================
- Coverage   10.65%   3.68%   -6.98%     
=========================================
  Files         729     512     -217     
  Lines       51075   37282   -13793     
  Branches     6572    1645    -4927     
=========================================
- Hits         5443    1373    -4070     
+ Misses      41225   35048    -6177     
+ Partials     4407     861    -3546     
Impacted Files Coverage Δ
...tion/include/traffic_light_map_visualizer/node.hpp
...mon/autoware_auto_common/test/test_angle_utils.cpp
control/trajectory_follower/src/mpc_utils.cpp
...r_nodes/test/test_longitudinal_controller_node.cpp
...oware_auto_geometry/include/geometry/common_2d.hpp
...tor/nodes/costmap_generator/objects_to_costmap.cpp
...e_auto_geometry/test/include/test_spatial_hash.hpp
map/lanelet2_extension/src/sample_code.cpp
...ion/regulatory_elements/autoware_traffic_light.hpp
...ctory_follower/include/trajectory_follower/mpc.hpp
... and 207 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d3ee50...5c78e9b. Read the comment docs.

xmfcx
xmfcx previously approved these changes Apr 5, 2022
Copy link
Contributor

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good to have them formatted well! I hope it also plays well with CLion too but not a big deal.

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
@kenji-miyake kenji-miyake marked this pull request as ready for review April 5, 2022 10:44
@kenji-miyake kenji-miyake enabled auto-merge (squash) April 5, 2022 10:45
@kenji-miyake kenji-miyake merged commit 1160713 into main Apr 5, 2022
@kenji-miyake kenji-miyake deleted the update-pre-commit-hooks-ros branch April 5, 2022 14:49
TomohitoAndo added a commit to TomohitoAndo/autoware.universe that referenced this pull request May 16, 2022
* ci(pre-commit): update pre-commit-hooks-ros

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
* ci(pre-commit): update pre-commit-hooks-ros

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* ci(pre-commit): update pre-commit-hooks-ros

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* ci(pre-commit): update pre-commit-hooks-ros

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
* ci(pre-commit): update pre-commit-hooks-ros

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Jul 3, 2023
autowarefoundation#625)

fix(behavior_path_planner): support separated lanes in getIntersectionTurnSignalInfo (autowarefoundation#4085)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants