-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pointcloud_preprocessor): enable to count empty pointclouds topic in concatenate pointclouds nodelet #6277
Merged
miursh
merged 2 commits into
autowarefoundation:main
from
YoshiRi:fix/concatenate_sync_nodelet_to_accept_zero_pointclouds
Feb 6, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
github-actions
bot
added
the
component:sensing
Data acquisition from sensors, drivers, preprocessing. (auto-assigned)
label
Feb 1, 2024
@YoshiRi
|
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
miursh
added
the
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Feb 6, 2024
miursh
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
confirmed with topic hz
before:
average rate: 8.285
min: 0.100s max: 0.164s std dev: 0.02018s window: 10
average rate: 8.328
min: 0.099s max: 0.157s std dev: 0.01780s window: 10
average rate: 7.838
min: 0.100s max: 0.179s std dev: 0.02874s window: 10
after
average rate: 10.014
min: 0.082s max: 0.114s std dev: 0.00906s window: 10
average rate: 10.078
min: 0.090s max: 0.110s std dev: 0.00518s window: 10
average rate: 9.975
min: 0.094s max: 0.107s std dev: 0.00405s window: 10
YoshiRi
deleted the
fix/concatenate_sync_nodelet_to_accept_zero_pointclouds
branch
February 7, 2024 05:39
shmpwk
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Feb 7, 2024
…c in concatenate pointclouds nodelet (autowarefoundation#6277) * feat: enable to count empty pointclouds topic Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * fix: time sync function to adapt empty pc topic Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> --------- Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
anhnv3991
pushed a commit
to anhnv3991/autoware.universe
that referenced
this pull request
Feb 13, 2024
…c in concatenate pointclouds nodelet (autowarefoundation#6277) * feat: enable to count empty pointclouds topic Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * fix: time sync function to adapt empty pc topic Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> --------- Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
StepTurtle
pushed a commit
to StepTurtle/autoware.universe
that referenced
this pull request
Feb 28, 2024
…c in concatenate pointclouds nodelet (autowarefoundation#6277) * feat: enable to count empty pointclouds topic Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * fix: time sync function to adapt empty pc topic Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> --------- Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…c in concatenate pointclouds nodelet (autowarefoundation#6277) * feat: enable to count empty pointclouds topic Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * fix: time sync function to adapt empty pc topic Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> --------- Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:sensing
Data acquisition from sensors, drivers, preprocessing. (auto-assigned)
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem
PR solutions
Related links
TIER IV INTERNAL SLACK DISCUSSION
Tests performed
Tested with jpntaxi settings and rosbag.
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.