-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(merge_from_private): fix stop position calculation #6286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
Feb 1, 2024
soblin
force-pushed
the
feat/merge_from_private
branch
2 times, most recently
from
February 2, 2024 03:01
7a8d70b
to
b801d7e
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6286 +/- ##
=======================================
Coverage 14.38% 14.38%
=======================================
Files 1907 1907
Lines 129943 129943
Branches 37616 37616
=======================================
Hits 18695 18695
Misses 90238 90238
Partials 21010 21010
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin
force-pushed
the
feat/merge_from_private
branch
from
February 2, 2024 06:42
b801d7e
to
d67d132
Compare
soblin
requested review from
kyoichi-sugahara,
shmpwk,
takayuki5168 and
tkimura4
as code owners
February 2, 2024 06:45
takayuki5168
approved these changes
Feb 2, 2024
anhnv3991
pushed a commit
to anhnv3991/autoware.universe
that referenced
this pull request
Feb 13, 2024
…ation#6286) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…ation#6286) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin
added a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 23, 2024
…ation#6286) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin
added a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 23, 2024
…ation#6286) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
saka1-s
pushed a commit
to saka1-s/autoware.universe
that referenced
this pull request
Nov 9, 2024
…ation#6286) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In https://github.com/autowarefoundation/autoware.universe/pull/5972/files, the stopline offset confused with baselink2front.
Related links
Tests performed
https://evaluation.tier4.jp/evaluation/reports/ed4aeae1-f94b-580e-81e1-bcfa42680e6f?project_id=prd_jt
before
after
Notes for reviewers
Interface changes
none
Effects on system behavior
none
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.