Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(merge_from_private): fix stop position calculation #6286

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Feb 1, 2024

Description

In https://github.com/autowarefoundation/autoware.universe/pull/5972/files, the stopline offset confused with baselink2front.

Related links

Tests performed

https://evaluation.tier4.jp/evaluation/reports/ed4aeae1-f94b-580e-81e1-bcfa42680e6f?project_id=prd_jt

before

image

after

image

Notes for reviewers

Interface changes

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Feb 1, 2024
@soblin soblin force-pushed the feat/merge_from_private branch 2 times, most recently from 7a8d70b to b801d7e Compare February 2, 2024 03:01
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (cc266ea) 14.38% compared to head (d67d132) 14.38%.
Report is 9 commits behind head on main.

Files Patch % Lines
...ction_module/src/scene_merge_from_private_road.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6286   +/-   ##
=======================================
  Coverage   14.38%   14.38%           
=======================================
  Files        1907     1907           
  Lines      129943   129943           
  Branches    37616    37616           
=======================================
  Hits        18695    18695           
  Misses      90238    90238           
  Partials    21010    21010           
Flag Coverage Δ *Carryforward flag
differential 4.69% <0.00%> (?)
total 14.38% <ø> (+<0.01%) ⬆️ Carriedforward from cc266ea

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin marked this pull request as ready for review February 2, 2024 06:45
@soblin soblin enabled auto-merge (squash) February 2, 2024 06:53
@soblin soblin merged commit 9c436bf into autowarefoundation:main Feb 2, 2024
21 of 22 checks passed
@soblin soblin deleted the feat/merge_from_private branch February 2, 2024 07:58
anhnv3991 pushed a commit to anhnv3991/autoware.universe that referenced this pull request Feb 13, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
soblin added a commit to tier4/autoware.universe that referenced this pull request Oct 23, 2024
soblin added a commit to tier4/autoware.universe that referenced this pull request Oct 23, 2024
saka1-s pushed a commit to saka1-s/autoware.universe that referenced this pull request Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants