Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_start_planner_module): check if pull_out_path is empty #6318

Merged

Conversation

beyzanurkaya
Copy link
Contributor

Description

Fixes: #6317

Tests performed

start_planner.mp4

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: beyza <bnk@leodrive.ai>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Feb 5, 2024
Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shmpwk shmpwk added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 5, 2024
@shmpwk shmpwk enabled auto-merge (squash) February 5, 2024 08:40
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9b4d7e4) 14.91% compared to head (10b8453) 14.91%.
Report is 4 commits behind head on main.

Files Patch % Lines
..._start_planner_module/src/start_planner_module.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6318   +/-   ##
=======================================
  Coverage   14.91%   14.91%           
=======================================
  Files        1817     1817           
  Lines      125357   125344   -13     
  Branches    37640    37630   -10     
=======================================
  Hits        18693    18693           
+ Misses      85652    85639   -13     
  Partials    21012    21012           
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.91% <ø> (+<0.01%) ⬆️ Carriedforward from 9b4d7e4

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shmpwk shmpwk merged commit b9c0a6d into autowarefoundation:main Feb 5, 2024
30 of 32 checks passed
shmpwk pushed a commit to tier4/autoware.universe that referenced this pull request Feb 5, 2024
…pty (autowarefoundation#6318)

check pull_out_path is empty

Signed-off-by: beyza <bnk@leodrive.ai>
Co-authored-by: beyza <bnk@leodrive.ai>
zulfaqar-azmi-t4 pushed a commit to zulfaqar-azmi-t4/autoware.universe that referenced this pull request Feb 6, 2024
…pty (autowarefoundation#6318)

check pull_out_path is empty

Signed-off-by: beyza <bnk@leodrive.ai>
Co-authored-by: beyza <bnk@leodrive.ai>
anhnv3991 pushed a commit to anhnv3991/autoware.universe that referenced this pull request Feb 13, 2024
…pty (autowarefoundation#6318)

check pull_out_path is empty

Signed-off-by: beyza <bnk@leodrive.ai>
Co-authored-by: beyza <bnk@leodrive.ai>
@beyzanurkaya beyzanurkaya deleted the bnk/dev/behavior-planning-dies branch March 5, 2024 09:33
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…pty (autowarefoundation#6318)

check pull_out_path is empty

Signed-off-by: beyza <bnk@leodrive.ai>
Co-authored-by: beyza <bnk@leodrive.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

behavior_planning_container dies because of the start_planner
3 participants