-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(behavior_path_start_planner_module): check if pull_out_path is empty #6318
fix(behavior_path_start_planner_module): check if pull_out_path is empty #6318
Conversation
Signed-off-by: beyza <bnk@leodrive.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6318 +/- ##
=======================================
Coverage 14.91% 14.91%
=======================================
Files 1817 1817
Lines 125357 125344 -13
Branches 37640 37630 -10
=======================================
Hits 18693 18693
+ Misses 85652 85639 -13
Partials 21012 21012
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…pty (autowarefoundation#6318) check pull_out_path is empty Signed-off-by: beyza <bnk@leodrive.ai> Co-authored-by: beyza <bnk@leodrive.ai>
…pty (autowarefoundation#6318) check pull_out_path is empty Signed-off-by: beyza <bnk@leodrive.ai> Co-authored-by: beyza <bnk@leodrive.ai>
…pty (autowarefoundation#6318) check pull_out_path is empty Signed-off-by: beyza <bnk@leodrive.ai> Co-authored-by: beyza <bnk@leodrive.ai>
…pty (autowarefoundation#6318) check pull_out_path is empty Signed-off-by: beyza <bnk@leodrive.ai> Co-authored-by: beyza <bnk@leodrive.ai>
Description
Fixes: #6317
Tests performed
start_planner.mp4
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.