Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(start_planner): consider backward completion before preparing blinker #6558

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Mar 7, 2024

Description

In the following PRs

Related links

Tests performed

https://evaluation.tier4.jp/evaluation/reports/02465796-fdcb-5949-89d7-aa5dd8ec3e85?project_id=prd_jt

If the prepare time is set to 3 seconds, ego stops a for while before starting forward driving.

RT1-5582-2024-03-07_14.17.24.mp4
RT1-5582-2024-03-07_15.34.05.mp4

Notes for reviewers

Interface changes

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Mar 7, 2024
@soblin soblin marked this pull request as ready for review March 7, 2024 06:32
Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@soblin soblin added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 7, 2024
@soblin soblin enabled auto-merge (squash) March 7, 2024 08:12
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 14.80%. Comparing base (7081a61) to head (09f4958).
Report is 1 commits behind head on main.

Files Patch % Lines
..._start_planner_module/src/start_planner_module.cpp 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6558      +/-   ##
==========================================
- Coverage   14.80%   14.80%   -0.01%     
==========================================
  Files        1917     1917              
  Lines      132086   132087       +1     
  Branches    39262    39262              
==========================================
  Hits        19553    19553              
- Misses      90715    90716       +1     
  Partials    21818    21818              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.80% <ø> (+<0.01%) ⬆️ Carriedforward from 7081a61

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin merged commit 1bbbb2a into autowarefoundation:main Mar 7, 2024
34 of 37 checks passed
@soblin soblin deleted the fix/start-planner/prepare-blinker-after-backward-completion branch March 7, 2024 08:13
soblin added a commit to tier4/autoware.universe that referenced this pull request Mar 7, 2024
…nker (autowarefoundation#6558)

consider backward completion

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin added a commit to tier4/autoware.universe that referenced this pull request Mar 8, 2024
…nker (autowarefoundation#6558)

consider backward completion

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin added a commit to tier4/autoware.universe that referenced this pull request Mar 8, 2024
fix(start_planner): consider backward completion before preparing blinker (autowarefoundation#6558)
0x126 pushed a commit to tier4/autoware.universe that referenced this pull request Mar 11, 2024
…nker (autowarefoundation#6558)

consider backward completion

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
HansRobo pushed a commit that referenced this pull request Mar 12, 2024
…nker (#6558)

consider backward completion

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
kaigohirao pushed a commit to kaigohirao/autoware.universe that referenced this pull request Mar 22, 2024
…nker (autowarefoundation#6558)

consider backward completion

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: kaigohirao <kaigo.hirao@proxima-ai-tech.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…nker (autowarefoundation#6558)

consider backward completion

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants