-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(start_planner): consider backward completion before preparing blinker #6558
fix(start_planner): consider backward completion before preparing blinker #6558
Conversation
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6558 +/- ##
==========================================
- Coverage 14.80% 14.80% -0.01%
==========================================
Files 1917 1917
Lines 132086 132087 +1
Branches 39262 39262
==========================================
Hits 19553 19553
- Misses 90715 90716 +1
Partials 21818 21818
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…nker (autowarefoundation#6558) consider backward completion Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…nker (autowarefoundation#6558) consider backward completion Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
fix(start_planner): consider backward completion before preparing blinker (autowarefoundation#6558)
…nker (autowarefoundation#6558) consider backward completion Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…nker (#6558) consider backward completion Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
…nker (autowarefoundation#6558) consider backward completion Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> Signed-off-by: kaigohirao <kaigo.hirao@proxima-ai-tech.com>
…nker (autowarefoundation#6558) consider backward completion Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Description
In the following PRs
I intended to "let the vehicle stop for a while before starting pull out action to turn the blinker for a specific time", but forgot the case where the vehicle first drives backward and then start pull out by forward driving. I changed it to start the "blinker preparation" when forward-driving started.
Related links
Tests performed
https://evaluation.tier4.jp/evaluation/reports/02465796-fdcb-5949-89d7-aa5dd8ec3e85?project_id=prd_jt
If the prepare time is set to 3 seconds, ego stops a for while before starting forward driving.
RT1-5582-2024-03-07_14.17.24.mp4
RT1-5582-2024-03-07_15.34.05.mp4
Notes for reviewers
Interface changes
none
Effects on system behavior
none
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.