feat(strat_planner): add a prepare time for blinker before taking action for approval #6438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:planning
7 tasks
soblin
requested review from
danielsanchezaran,
kosuke55,
kyoichi-sugahara,
satoshi-ota,
shmpwk,
TomohitoAndo and
tkimura4
as code owners
planning/behavior_path_start_planner_module/config/start_planner.param.yaml
Outdated
Show resolved
Hide resolved
kyoichi-sugahara
approved these changes
Feb 17, 2024
soblin
force-pushed
the
fix/start-planner/blinker-on-start
branch
from
84b91ea
to
3b34c92
Compare
github-actions
bot
added
type:documentation
soblin
added
the
tag:run-build-and-test-differential
…ion for approval Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
This reverts commit bcc889c. Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin
force-pushed
the
fix/start-planner/blinker-on-start
branch
from
8e05b2b
to
e862e0e
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6438 +/- ##
==========================================
- Coverage 15.13% 15.13% -0.01%
==========================================
Files 1819 1819
Lines 126013 126022 +9
Branches 38180 38180
==========================================
Hits 19073 19073
- Misses 85552 85561 +9
Partials 21388 21388
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
soblin
added a commit
to tier4/autoware.universe
that referenced
this pull request
Feb 28, 2024
…ion for approval (autowarefoundation#6438) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
StepTurtle
pushed a commit
to StepTurtle/autoware.universe
that referenced
this pull request
Feb 28, 2024
…ion for approval (autowarefoundation#6438) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
7 tasks
0x126
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Mar 11, 2024
…ion for approval (autowarefoundation#6438) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
HansRobo
pushed a commit
that referenced
this pull request
Mar 12, 2024
…ion for approval (#6438) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…ion for approval (autowarefoundation#6438) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After the module is approved, for a specified duration the module keeps stopline and blinker.
autowarefoundation/autoware_launch#881
Related links
https://tier4.atlassian.net/browse/RT0-30644
Tests performed
In the below video, at [00:22] the start_planner is approved but it waits for 3second and then the vehicle start the pull out action.
goal_planner.-2024-02-20_13.45.59.mp4
Notes for reviewers
Interface changes
none
Effects on system behavior
none
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.