Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): stop lane_driving planners in non-lane-driving scenario #668

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Apr 11, 2022

Description

Deactivate lane_driving planners (behavior_path_planner, behavior_velocity_planner, obstacle_stop_planner, etc) in non-lane-driving scenario. In the implementation, let the behavior_path_planner subscribe to the scenario topic and run only when the scenario is lane_driving, which is the same way employed in the parking planner module.

Related links

for autoware_launch:
tier4/autoware_launch#275

Tests performed

Run planning simulator in oss-sample map (kashiwanoha) and checked if the switching between the lane-driving and parking works correctly.

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #668 (503163d) into main (973cc80) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head 503163d differs from pull request most recent head 7b938a6. Consider uploading reports for the commit 7b938a6 to get more accurate results

@@            Coverage Diff             @@
##             main     #668      +/-   ##
==========================================
- Coverage   10.61%   10.59%   -0.03%     
==========================================
  Files         734      732       -2     
  Lines       51660    51760     +100     
  Branches     6596     6596              
==========================================
  Hits         5482     5482              
- Misses      41718    41818     +100     
  Partials     4460     4460              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.62% <0.00%> (+0.01%) ⬆️ Carriedforward from 9affde2

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...or_path_planner/src/behavior_path_planner_node.cpp 0.00% <0.00%> (ø)
...i_object_tracker/src/multi_object_tracker_core.cpp 0.00% <0.00%> (ø)
...lanner/include/obstacle_avoidance_planner/node.hpp 0.00% <0.00%> (ø)
...tracker/src/tracker/model/pass_through_tracker.cpp
...ect_tracker/tracker/model/pass_through_tracker.hpp

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dbbaee...7b938a6. Read the comment docs.

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TakaHoribe TakaHoribe merged commit 36165da into autowarefoundation:main Apr 12, 2022
@TakaHoribe TakaHoribe deleted the feature/stop-lanedriving-on-parking-scenario branch April 12, 2022 02:05
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
…riving scenario (tier4#668)

* stop lanedriving in parking scenario

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* use skip_first

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* add scenario remap in launch

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* replace warn to info

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…riving scenario (tier4#668)

* stop lanedriving in parking scenario

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* use skip_first

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* add scenario remap in launch

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* replace warn to info

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…riving scenario (tier4#668)

* stop lanedriving in parking scenario

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* use skip_first

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* add scenario remap in launch

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* replace warn to info

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
…riving scenario (tier4#668)

* stop lanedriving in parking scenario

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* use skip_first

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* add scenario remap in launch

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* replace warn to info

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
1222-takeshi pushed a commit to 1222-takeshi/autoware.universe that referenced this pull request Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants