-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(behavior_path_planner): stop lane_driving planners in non-lane-driving scenario #668
feat(behavior_path_planner): stop lane_driving planners in non-lane-driving scenario #668
Conversation
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
503163d
to
7b938a6
Compare
Codecov Report
@@ Coverage Diff @@
## main #668 +/- ##
==========================================
- Coverage 10.61% 10.59% -0.03%
==========================================
Files 734 732 -2
Lines 51660 51760 +100
Branches 6596 6596
==========================================
Hits 5482 5482
- Misses 41718 41818 +100
Partials 4460 4460
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…riving scenario (tier4#668) * stop lanedriving in parking scenario Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * use skip_first Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * add scenario remap in launch Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * replace warn to info Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
…riving scenario (tier4#668) * stop lanedriving in parking scenario Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * use skip_first Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * add scenario remap in launch Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * replace warn to info Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
…riving scenario (tier4#668) * stop lanedriving in parking scenario Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * use skip_first Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * add scenario remap in launch Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * replace warn to info Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
…riving scenario (tier4#668) * stop lanedriving in parking scenario Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * use skip_first Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * add scenario remap in launch Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * replace warn to info Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
chore: sync upstream
Description
Deactivate lane_driving planners (behavior_path_planner, behavior_velocity_planner, obstacle_stop_planner, etc) in non-lane-driving scenario. In the implementation, let the behavior_path_planner subscribe to the scenario topic and run only when the scenario is lane_driving, which is the same way employed in the parking planner module.
Related links
for autoware_launch:
tier4/autoware_launch#275
Tests performed
Run planning simulator in oss-sample map (kashiwanoha) and checked if the switching between the lane-driving and parking works correctly.
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.