Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(map_tf_generator): modify build error in rolling #778

Merged
merged 1 commit into from
Apr 25, 2022
Merged

fix(map_tf_generator): modify build error in rolling #778

merged 1 commit into from
Apr 25, 2022

Conversation

wep21
Copy link
Contributor

@wep21 wep21 commented Apr 24, 2022

Description

This PR fixes the following build error on rolling distro.

gmake[2]: *** [CMakeFiles/map_tf_generator_node.dir/build.make:76: CMakeFiles/map_tf_generator_node.dir/src/map_tf_generator_node.cpp.o] エラー 1
gmake[1]: *** [CMakeFiles/Makefile2:139: CMakeFiles/map_tf_generator_node.dir/all] エラー 2
gmake: *** [Makefile:146: all] エラー 2
--- stderr: map_tf_generator
/home/daisuke/workspace/autoware.proj.universe.rolling/src/autoware/universe/map/map_tf_generator/src/map_tf_generator_node.cpp:91:10: fatal error: rclcpp_components/register_node_macro.hpp: そのようなファイルやディレクトリはありません
   91 | #include <rclcpp_components/register_node_macro.hpp>

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
@wep21 wep21 added ros:rolling Continuous ROS Rolling Ridley release. ros:humble ROS Humble Hawksbill release. labels Apr 24, 2022
@codecov
Copy link

codecov bot commented Apr 24, 2022

Codecov Report

Merging #778 (c42ed8e) into main (a13a214) will not change coverage.
The diff coverage is 40.00%.

@@          Coverage Diff          @@
##            main    #778   +/-   ##
=====================================
  Coverage   9.63%   9.63%           
=====================================
  Files        907     907           
  Lines      56544   56544           
  Branches    6694    6694           
=====================================
  Hits        5448    5448           
  Misses     46601   46601           
  Partials    4495    4495           
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 9.63% <40.00%> (ø) Carriedforward from a13a214

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...clude/autoware_auto_tf2/tf2_autoware_auto_msgs.hpp 100.00% <ø> (ø)
...ware_auto_tf2/test/test_tf2_autoware_auto_msgs.cpp 42.29% <ø> (ø)
...ion_common/include/motion_common/motion_common.hpp 0.00% <ø> (ø)
.../motion_common/src/motion_common/motion_common.cpp 2.19% <ø> (ø)
...tion_testing/src/motion_testing/motion_testing.cpp 44.76% <ø> (ø)
..._simulator/test/test_simple_planning_simulator.cpp 44.35% <ø> (ø)
...include/ad_service_state_monitor/state_machine.hpp 0.00% <ø> (ø)
...ate_monitor_node/ad_service_state_monitor_node.cpp 0.00% <ø> (ø)
.../src/ad_service_state_monitor_node/diagnostics.cpp 0.00% <ø> (ø)
...rc/ad_service_state_monitor_node/state_machine.cpp 0.00% <0.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a453c23...c42ed8e. Read the comment docs.

@wep21 wep21 enabled auto-merge (squash) April 24, 2022 16:57
@wep21 wep21 merged commit 86a3ef8 into autowarefoundation:main Apr 25, 2022
@wep21 wep21 deleted the fix/rolling-map-tf-generator branch April 25, 2022 01:59
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
h-ohta referenced this pull request in tier4/autoware.universe May 15, 2023
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
h-ohta referenced this pull request in tier4/autoware.universe May 15, 2023
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ros:humble ROS Humble Hawksbill release. ros:rolling Continuous ROS Rolling Ridley release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants