-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(obstacle_cruise_planner): add diagnostics publishing to cruise planner #7836
feat(obstacle_cruise_planner): add diagnostics publishing to cruise planner #7836
Conversation
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7836 +/- ##
==========================================
- Coverage 28.67% 28.67% -0.01%
==========================================
Files 1587 1588 +1
Lines 116303 116360 +57
Branches 49651 49680 +29
==========================================
+ Hits 33354 33367 +13
- Misses 73864 73907 +43
- Partials 9085 9086 +1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
9ee408d
into
autowarefoundation:main
…lanner (autowarefoundation#7836) add diagnostics publishing to cruise planner Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
…lanner (autowarefoundation#7836) add diagnostics publishing to cruise planner Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> Signed-off-by: palas21 <palas21@itu.edu.tr>
…lanner (autowarefoundation#7836) add diagnostics publishing to cruise planner Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
…lanner (#7836) add diagnostics publishing to cruise planner Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
…lanner (autowarefoundation#7836) add diagnostics publishing to cruise planner Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Description
Add an output to /diagnostics showing data about stop.
Also refactored a complex boolean logic to improve readability in node.cpp
Related links
Parent Issue:
How was this PR tested?
PSim
ros2 topic echo /diagnostics:
Example output:
Stop:
header:
stamp:
sec: 1720074365
nanosec: 133470854
frame_id: map
status:
name: obstacle_cruise_planner
message: ''
hardware_id: ''
values:
value: stop
value: '{89607.856760, 43010.903088, 6.367879}'
value: '{0.959131, 0.000695, -0.002355, 0.282953}'
value: '0.132687'
value: '{89614.570092, 43016.732919, 6.323306}'
No stop decision:
header:
stamp:
sec: 1720073879
nanosec: 55494950
frame_id: map
status:
name: obstacle_cruise_planner
message: ''
hardware_id: ''
values:
value: none
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.