Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(obstacle_cruise_planner): add diagnostics publishing to cruise planner #7836

Conversation

danielsanchezaran
Copy link
Contributor

Description

Add an output to /diagnostics showing data about stop.
Also refactored a complex boolean logic to improve readability in node.cpp

Related links

Parent Issue:

  • Link

How was this PR tested?

PSim

ros2 topic echo /diagnostics:

Example output:
Stop:
header:
stamp:
sec: 1720074365
nanosec: 133470854
frame_id: map
status:

  • level: "\0"
    name: obstacle_cruise_planner
    message: ''
    hardware_id: ''
    values:
    • key: decision
      value: stop
    • key: stop_position
      value: '{89607.856760, 43010.903088, 6.367879}'
    • key: stop_orientation
      value: '{0.959131, 0.000695, -0.002355, 0.282953}'
    • key: distance_to_stop_pose
      value: '0.132687'
    • key: collision_point
      value: '{89614.570092, 43016.732919, 6.323306}'

No stop decision:


header:
stamp:
sec: 1720073879
nanosec: 55494950
frame_id: map
status:

  • level: "\0"
    name: obstacle_cruise_planner
    message: ''
    hardware_id: ''
    values:
    • key: decision
      value: none

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
@danielsanchezaran danielsanchezaran marked this pull request as ready for review July 4, 2024 06:28
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 4, 2024
Copy link

github-actions bot commented Jul 4, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielsanchezaran danielsanchezaran added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 4, 2024
@danielsanchezaran danielsanchezaran enabled auto-merge (squash) July 4, 2024 06:35
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 31.42857% with 24 lines in your changes missing coverage. Please review.

Project coverage is 28.67%. Comparing base (b54d57d) to head (c77f49a).
Report is 8 commits behind head on main.

Files Patch % Lines
..._obstacle_cruise_planner/src/planner_interface.cpp 31.25% 22 Missing ⚠️
...ning/autoware_obstacle_cruise_planner/src/node.cpp 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7836      +/-   ##
==========================================
- Coverage   28.67%   28.67%   -0.01%     
==========================================
  Files        1587     1588       +1     
  Lines      116303   116360      +57     
  Branches    49651    49680      +29     
==========================================
+ Hits        33354    33367      +13     
- Misses      73864    73907      +43     
- Partials     9085     9086       +1     
Flag Coverage Δ *Carryforward flag
differential 6.68% <31.42%> (?)
total 28.67% <ø> (+<0.01%) ⬆️ Carriedforward from 7a6bf39

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielsanchezaran danielsanchezaran merged commit 9ee408d into autowarefoundation:main Jul 4, 2024
36 of 39 checks passed
@danielsanchezaran danielsanchezaran deleted the feat/add-diag-pub-to-cruise-planner branch July 4, 2024 06:54
danielsanchezaran added a commit to tier4/autoware.universe that referenced this pull request Jul 4, 2024
…lanner (autowarefoundation#7836)

add diagnostics publishing to cruise planner

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
palas21 pushed a commit to palas21/autoware.universe that referenced this pull request Jul 12, 2024
…lanner (autowarefoundation#7836)

add diagnostics publishing to cruise planner

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: palas21 <palas21@itu.edu.tr>
tby-udel pushed a commit to tby-udel/autoware.universe that referenced this pull request Jul 14, 2024
…lanner (autowarefoundation#7836)

add diagnostics publishing to cruise planner

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
…lanner (#7836)

add diagnostics publishing to cruise planner

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Ariiees pushed a commit to Ariiees/autoware.universe that referenced this pull request Jul 22, 2024
…lanner (autowarefoundation#7836)

add diagnostics publishing to cruise planner

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants