feat(obstacle_cruise_planner): add diagnostics publishing to cruise planner #7836
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
Change in average Code Health of affected files: +0.11 (4.65 -> 4.75)
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 5 findings(s) ✅
Details
🚩 Declining Code Health (highest to lowest):
- Complex Method planner_interface.cpp: PlannerInterface::generateStopTrajectory
✅ Improving Code Health:
- Overall Code Complexity node.cpp
- Overall Code Complexity planner_interface.cpp
- Complex Method node.cpp: ObstacleCruisePlannerNode::onTrajectory
- Complex Conditional node.cpp: ObstacleCruisePlannerNode::onTrajectory
- Primitive Obsession planner_interface.cpp
Annotations
Check notice on line 1 in planning/autoware_obstacle_cruise_planner/src/node.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Lines of Code in a Single File
The lines of code increases from 1484 to 1485, improve code health by reducing it to 1000. The number of Lines of Code in a single file. More Lines of Code lowers the code health.
Check notice on line 561 in planning/autoware_obstacle_cruise_planner/src/node.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Complex Method
ObstacleCruisePlannerNode::onTrajectory decreases in cyclomatic complexity from 12 to 11, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 561 in planning/autoware_obstacle_cruise_planner/src/node.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Complex Conditional
ObstacleCruisePlannerNode::onTrajectory decreases from 1 complex conditionals with 4 branches to 1 complex conditionals with 2 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.
Check notice on line 1 in planning/autoware_obstacle_cruise_planner/src/node.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Overall Code Complexity
The mean cyclomatic complexity decreases from 4.61 to 4.59, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
Check warning on line 481 in planning/autoware_obstacle_cruise_planner/src/planner_interface.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
PlannerInterface::generateStopTrajectory already has high cyclomatic complexity, and now it increases in Lines of Code from 168 to 172. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 1 in planning/autoware_obstacle_cruise_planner/src/planner_interface.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Overall Code Complexity
The mean cyclomatic complexity decreases from 6.38 to 5.78, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
Check notice on line 1 in planning/autoware_obstacle_cruise_planner/src/planner_interface.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Primitive Obsession
The ratio of primitive types in function arguments decreases from 54.84% to 48.57%, threshold = 30.0%. The functions in this file have too many primitive types (e.g. int, double, float) in their function argument lists. Using many primitive types lead to the code smell Primitive Obsession. Avoid adding more primitive arguments.