Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fix format of package.xml #844

Merged
merged 1 commit into from
May 3, 2022
Merged

Conversation

kenji-miyake
Copy link
Contributor

@kenji-miyake kenji-miyake commented May 3, 2022

Description

  • Remove unnecessary comments
  • Use autoware_lint_common
  • Use package_format3
  • Use Apache License 2.0
  • Write <?xml version="1.0"?> and <?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
  • Minor style changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kenji-miyake kenji-miyake requested a review from wep21 May 3, 2022 07:05
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #844 (0fe9b71) into main (54e342a) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #844   +/-   ##
=====================================
  Coverage   9.58%   9.58%           
=====================================
  Files        925     925           
  Lines      57411   57411           
  Branches    6863    6863           
=====================================
  Hits        5502    5502           
  Misses     47384   47384           
  Partials    4525    4525           
Flag Coverage Δ *Carryforward flag
differential 10.67% <ø> (?)
total 9.58% <ø> (ø) Carriedforward from 54e342a

*This pull request uses carry forward flags. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54e342a...0fe9b71. Read the comment docs.

@kenji-miyake kenji-miyake merged commit 20c6dd4 into main May 3, 2022
@kenji-miyake kenji-miyake deleted the fix-package-xml-format branch May 3, 2022 10:31
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
yn-mrse referenced this pull request in tier4/autoware.universe Dec 22, 2022
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants