fix(autoware_image_projection_based_fusion): make optional to consider lens distortion in the point projection #9233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mon.param.yaml Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
github-actions
bot
added
component:perception
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
technolojin
changed the title
4 tasks
technolojin
added
the
tag:run-build-and-test-differential
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9233 +/- ##
==========================================
- Coverage 29.02% 29.02% -0.01%
==========================================
Files 1325 1325
Lines 102579 102597 +18
Branches 39783 39791 +8
==========================================
+ Hits 29778 29779 +1
- Misses 69933 69949 +16
- Partials 2868 2869 +1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
technolojin
requested review from
badai-nguyen,
kminoda,
ktro2828,
miursh,
tzhong518,
YoshiRi and
yukkysaito
as code owners
|
@technolojin Could you retest on Evaluator with |
technolojin
deleted the
fix/image-projection/optionize-lens-distortion
branch
Ericpotato
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 6, 2024
…r lens distortion in the point projection (autowarefoundation#9233) chore: add point_project_to_unrectified_image parameter to fusion_common.param.yaml Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add option
point_project_to_unrectified_imageto switch whether if the point project considers lens distortion or not.This PR will be merged after PR autowarefoundation/autoware_launch#1207 is merged.
Related links
Lens distortion consideration #7053
How was this PR tested?
TIER IV INTERNAL
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.