refactor(docker): replace the multiple rosdep commands with resolve_rosdep_keys.sh.
#5424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
youtalk
added
type:containers
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
youtalk
changed the title
rosdep commands with resolve_rosdep_keys.sh.rosdep commands with resolve_rosdep_keys.sh.
youtalk
changed the title
rosdep commands with resolve_rosdep_keys.sh.rosdep commands with resolve_rosdep_keys.sh.
This was referenced Nov 12, 2024
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
|
NOTE: |
youtalk
added a commit
to youtalk/autoware
that referenced
this pull request
Nov 14, 2024
* chore(docker): remove `/autoware/log` after `colcon build` (autowarefoundation#5329) * chore(.github): always run `Show disk space` (autowarefoundation#5354) always show disk space Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * build(autoware.repos): remove ament_cmake fork repository (autowarefoundation#5360) Signed-off-by: Chengyong Lin <stclin@qq.com> * fix: remove `ndt_omp` (autowarefoundation#5390) Removed ndt_omp Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * fix: change the organization of `awsim_sensor_kit_launch` from RobotecAI to tier4 (autowarefoundation#5403) Fixed organization of `awsim_sensor_kit_launch` from RobotecAI to tier4 Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * chore(.devcontainer): rename `.devcontainer` directories (autowarefoundation#5407) rename .devcontainer dirs Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * feat(docker): integrate `cuda`/`no-cuda` jobs into single job (autowarefoundation#5363) * chore(.github): rename `bake-target` to `target-image` and add descriptions to args (autowarefoundation#5413) * rename target-image and add descriptions Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * fix feedback Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> --------- Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * feat(docker): install CUDA development/runtime libraries only 1 time (autowarefoundation#5419) * add base-cuda Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * update svg Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * not cache cuda packages Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * push base-cuda image Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * Update docker-build-and-push.yaml * Update docker-build-and-push-arm64.yaml * separate jobs Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> --------- Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * refactor(docker): replace the multiple `rosdep` commands with `resolve_rosdep_keys.sh`. (autowarefoundation#5424) * run resolve_rosdep_keys.sh Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * style(pre-commit): autofix * update .dockerignore Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * chmod +x Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * fix location Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * remove rosdep update Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> --------- Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * refactor(docker): replace the multiple `colcon` commands with `build_and_clean.sh`. (autowarefoundation#5425) * run resolve_rosdep_keys.sh Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * style(pre-commit): autofix * update .dockerignore Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * chmod +x Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * fix location Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * remove rosdep update Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * run build_and_clean.sh Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * style(pre-commit): autofix --------- Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * refactor(docker): replace the multiple `rm -rf` commands with `cleanup_system.sh`. (autowarefoundation#5426) * fix(.github): fix `target-image` (autowarefoundation#5428) fix target-image Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * chore: remove tvm_utility artifacts from Ansible tasks (autowarefoundation#5427) Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp> --------- Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> Signed-off-by: Chengyong Lin <stclin@qq.com> Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp> Co-authored-by: chgyg <99009754+ChgygLin@users.noreply.github.com> Co-authored-by: SakodaShintaro <rgbygscrsedppbwg@gmail.com> Co-authored-by: SakodaShintaro <shintaro.sakoda@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Esteve Fernandez <33620+esteve@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces the multiple
rosdepcommands in theDockerfilewith a shell script,resolve_rosdep_keys.sh, to improve the readability of theDockerfile.Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.