fix(docker): install CUDA developement libraries into -devel-cuda images
#5446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
youtalk
added
type:containers
youtalk
requested review from
xmfcx,
kaspermeck-arm,
mitsudome-r and
amadeuszsz
mitsudome-r
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
The code modification LGTM.
We can merge after the test passes.
amadeuszsz
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
LGTM, thank you for quick fix! Can we somehow make this kind of issues easier to catch? For the instance add -DFORCE_CUDA in humble CUDA pipeline, modify CMakeLists and let CI fail? This is just potential solution, maybe we can do it different way.
|
@amadeuszsz Good suggestion. I will do it next PR. |
|
It still seems to have no CUDA development libraries... https://github.com/autowarefoundation/autoware/actions/runs/11883999428/job/33112885695#step:7:6657 |
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
This was referenced Nov 18, 2024
This reverts commit 3fb57f6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
apt-get autoremovecommands withcleanup_apt.sh. #5447This PR fixes the CUDA development libraries error. This was caused by #5419.
https://github.com/autowarefoundation/autoware/pull/5419/files#diff-f34da55ca08f1a30591d8b0b3e885bcc678537b2a9a4aadea4f190806b374ddcR277
Tests performed
https://github.com/autowarefoundation/autoware/actions/runs/11888075075
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.