Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docker): add -DFORCE_CUDA=1 option to strictly build CUDA related packages #5449

Closed
wants to merge 2 commits into from

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Nov 18, 2024

Description

Following #5446 (review), this PR adds the -DFORCE_CUDA=1 option when performing the colcon build for universe-sensing-perception-devel-cuda, ensuring that the build is not skipped and always executed. This guarantees that the -devel-cuda image has the CUDA development libraries installed.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
@youtalk youtalk self-assigned this Nov 18, 2024
@youtalk youtalk added type:containers Docker containers, containerization of components, or container orchestration. component:openadkit Issues or Features related to Open AD Kit tag:run-health-check Run health-check labels Nov 18, 2024
@youtalk youtalk marked this pull request as ready for review November 18, 2024 08:18
Copy link
Contributor

@amadeuszsz amadeuszsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amadeuszsz
Copy link
Contributor

@youtalk
Thanks for this PR! DId you start refactor universe packages? If so, please close this PR in favor of your changes.
Otherwise let's merge this PR and then we can check if CI fails in linked PR.

@youtalk
Copy link
Member Author

youtalk commented Nov 18, 2024

I mistakenly thought the FORCE_CUDA option was already supported by default. When I tested it on a local container, the option was ignored. I will try a different method to enforce the build of CUDA packages.

@youtalk youtalk closed this Nov 18, 2024
@youtalk youtalk deleted the force-cuda-option branch November 18, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:openadkit Issues or Features related to Open AD Kit tag:run-health-check Run health-check type:containers Docker containers, containerization of components, or container orchestration.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants