Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(autoware_launch): remove duplicated path in planning launch #365

Merged

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented May 22, 2023

Description

Replace duplicated config path with a common arg.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kenji-miyake kenji-miyake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean!

soblin referenced this pull request in tier4/autoware_launch May 23, 2023
feat: add sync from autoware_launch:awf-latest -> autoware_launch.xx1:awf-latest-xx1
@TakaHoribe TakaHoribe merged commit 30b422a into autowarefoundation:main May 29, 2023
@TakaHoribe TakaHoribe deleted the use-common-arg-planning-launch branch May 29, 2023 07:08
rej55 pushed a commit to rej55/autoware_launch that referenced this pull request Jun 12, 2023
…tion (autowarefoundation#365)

* resolve conflict

Signed-off-by: kminoda <koji.m.minoda@gmail.com>

* update readme

Signed-off-by: kminoda <koji.m.minoda@gmail.com>
kminoda pushed a commit to kminoda/autoware_launch that referenced this pull request Sep 13, 2023
badai-nguyen pushed a commit to badai-nguyen/autoware_launch that referenced this pull request Oct 31, 2023
Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
badai-nguyen pushed a commit to badai-nguyen/autoware_launch that referenced this pull request Apr 16, 2024
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants