-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(autoware_launch): remove duplicated path in planning launch #365
Merged
TakaHoribe
merged 1 commit into
autowarefoundation:main
from
tier4:use-common-arg-planning-launch
May 29, 2023
Merged
refactor(autoware_launch): remove duplicated path in planning launch #365
TakaHoribe
merged 1 commit into
autowarefoundation:main
from
tier4:use-common-arg-planning-launch
May 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
yukkysaito
approved these changes
May 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kenji-miyake
approved these changes
May 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks clean!
soblin
referenced
this pull request
in tier4/autoware_launch
May 23, 2023
feat: add sync from autoware_launch:awf-latest -> autoware_launch.xx1:awf-latest-xx1
This was referenced May 30, 2023
rej55
pushed a commit
to rej55/autoware_launch
that referenced
this pull request
Jun 12, 2023
…tion (autowarefoundation#365) * resolve conflict Signed-off-by: kminoda <koji.m.minoda@gmail.com> * update readme Signed-off-by: kminoda <koji.m.minoda@gmail.com>
kminoda
pushed a commit
to kminoda/autoware_launch
that referenced
this pull request
Sep 13, 2023
chore: sync awf/autoware_launch
badai-nguyen
pushed a commit
to badai-nguyen/autoware_launch
that referenced
this pull request
Oct 31, 2023
Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
badai-nguyen
pushed a commit
to badai-nguyen/autoware_launch
that referenced
this pull request
Apr 16, 2024
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace duplicated config path with a common arg.
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.