Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(behavior_velocity_planner): load all module parameters #389

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Jun 7, 2023

Description

From this comment: #369 (comment). Load all module parameters by default. The user only needs to edit launch_modules.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@isamu-takagi isamu-takagi changed the title load all module parameters refactor(behavior_velocity_planner): load all module parameters Jun 7, 2023
Copy link
Contributor

@mehmetdogru mehmetdogru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@mehmetdogru mehmetdogru merged commit 4fb3a4c into autowarefoundation:main Jun 7, 2023
@isamu-takagi isamu-takagi deleted the refactor/launch-behavior-velocity-planner-fix branch June 8, 2023 01:43
rej55 pushed a commit to rej55/autoware_launch that referenced this pull request Jun 12, 2023
takayuki5168 referenced this pull request in tier4/autoware_launch Jun 21, 2023
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants